Re: [Nagios-charmers] [Merge] ~giulio.cervera/nagios-charm:bug/1860669 into nagios-charm:master

2020-02-16 Thread Xav Paice
The docs are pretty clear, this is an option for the main config file only, and given the age of Nagios 3 it's unlikely to be something that'll change any time soon. Since we're in the middle of a release, I'll postpone this till after the release and target for the next one. --

Re: [Nagios-charmers] [Merge] ~giulio.cervera/nagios-charm:bug/1860669 into nagios-charm:master

2020-02-16 Thread Xav Paice
Thanks for the contribution. I'm concerned that we have the code to enable the module, but nothing to actually deploy the module itself, meaning that this change alone doesn't achieve much. Adding the module would be ideally put into a subordinate charm, along with dropping a fresh config

[Nagios-charmers] [Merge] ~giulio.cervera/nagios-charm:bug/1860669 into nagios-charm:master

2020-02-03 Thread Canonical IS Mergebot
The proposal to merge ~giulio.cervera/nagios-charm:bug/1860669 into nagios-charm:master has been updated. Commit message changed to: Add support for enabling broker module For more details, see: https://code.launchpad.net/~giulio.cervera/nagios-charm/+git/nagios-charm/+merge/378449 -- Your

[Nagios-charmers] [Merge] ~giulio.cervera/nagios-charm:bug/1860669 into nagios-charm:master

2020-02-03 Thread Giulio Cervera
Giulio Cervera has proposed merging ~giulio.cervera/nagios-charm:bug/1860669 into nagios-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~giulio.cervera/nagios-charm/+git/nagios-charm/+merge/378449 -- Your team

Re: [Nagios-charmers] [Merge] ~giulio.cervera/nagios-charm:bug/1860669 into nagios-charm:master

2020-02-03 Thread Canonical IS Mergebot
This merge proposal is being monitored by mergebot. Change the status to Approved to merge. -- https://code.launchpad.net/~giulio.cervera/nagios-charm/+git/nagios-charm/+merge/378449 Your team Nagios Charm developers is requested to review the proposed merge of