The proposal to merge
~peter-sabaini/hw-health-charm:lp1817791-reduce-complexity into
hw-health-charm:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~peter-sabaini/hw-health-charm/+git/hw-health-charm/+merge/378151
--
Your team Nagios
Change successfully merged at revision c2b7b114521651685a96345feff88821f2a22fe4
--
https://code.launchpad.net/~peter-sabaini/hw-health-charm/+git/hw-health-charm/+merge/378151
Your team Nagios Charm developers is subscribed to branch
hw-health-charm:master.
--
Mailing list:
The proposal to merge
~peter-sabaini/hw-health-charm:lp1817791-reduce-complexity into
hw-health-charm:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~peter-sabaini/hw-health-charm/+git/hw-health-charm/+merge/378151
--
Your team
Cheers, updated msg formatting
--
https://code.launchpad.net/~peter-sabaini/hw-health-charm/+git/hw-health-charm/+merge/378151
Your team Nagios Charm developers is subscribed to branch
hw-health-charm:master.
--
Mailing list: https://launchpad.net/~nagios-charmers
Post to :
Review: Approve
Looks good. One minor comment inline which can be ignored or adjusted before
landing.
Diff comments:
> diff --git a/src/files/megacli/check_megacli.py
> b/src/files/megacli/check_megacli.py
> index ab3d99f..052927c 100755
> --- a/src/files/megacli/check_megacli.py
> +++
Peter Sabaini has proposed merging
~peter-sabaini/hw-health-charm:lp1817791-reduce-complexity into
hw-health-charm:master.
Commit message:
Refactor for complexity
Requested reviews:
Xav Paice (xavpaice)
Canonical IS Reviewers (canonical-is-reviewers)
For more details, see:
Review: Approve
LGTM
--
https://code.launchpad.net/~peter-sabaini/hw-health-charm/+git/hw-health-charm/+merge/378151
Your team Nagios Charm developers is subscribed to branch
hw-health-charm:master.
--
Mailing list: https://launchpad.net/~nagios-charmers
Post to :
This merge proposal is being monitored by mergebot. Change the status to
Approved to merge.
--
https://code.launchpad.net/~peter-sabaini/hw-health-charm/+git/hw-health-charm/+merge/378151
Your team Nagios Charm developers is subscribed to branch
hw-health-charm:master.
--
Mailing list:
The proposal to merge
~peter-sabaini/hw-health-charm:lp1817791-reduce-complexity into
hw-health-charm:master has been updated.
Commit message changed to:
Refactor for complexity
For more details, see:
https://code.launchpad.net/~peter-sabaini/hw-health-charm/+git/hw-health-charm/+merge/378151
9 matches
Mail list logo
