The proposal to merge ~xavpaice/hw-health-charm:add_ipmi into
hw-health-charm:master has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363682
--
Your team Nagios Charm developers is
Review: Approve
lgtm, +1 from my side
--
https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363682
Your team Nagios Charm developers is subscribed to branch
hw-health-charm:master.
--
Mailing list: https://launchpad.net/~nagios-charmers
Post to :
Currently have left the tox.ini with complexity at 20, need to add a second
commit (unrelated) to get the complexity down to 10, so it passes. We need to
raise a bug report to track that.
--
https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363682
Your team
I've addressed the comments, and squashed the commits to one.
--
https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363682
Your team Nagios Charm developers is subscribed to branch
hw-health-charm:master.
--
Mailing list: https://launchpad.net/~nagios-charmers
The proposal to merge ~xavpaice/hw-health-charm:add_ipmi into
hw-health-charm:master has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363681
--
Your team Nagios Charm developers is
The proposal to merge ~xavpaice/hw-health-charm:add_ipmi into
hw-health-charm:master has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363638
--
Your team Nagios Charm developers is
Review: Approve
Heya, thanks for the update. There's some minor things inline -- I'm ok with
raising bugs too to limit scope though.
Diff comments:
> diff --git a/src/actions/actions.py b/src/actions/actions.py
> new file mode 100755
> index 000..29d12cc
> --- /dev/null
> +++
Review: Resubmit
Thanks for the detailed review - I've address (most) of the comments. I've not
added all the docstrings requested as it's hard to know where to draw the line
between changes relevant to this branch and changes that just make the overall
code better - I suggest raising bugs
The proposal to merge ~xavpaice/hw-health-charm:add_ipmi into
hw-health-charm:master has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363593
--
Your team Nagios Charm developers is
One more suggestion, README.md possibly should mention ipmi features.
Other than that, no further comments
--
https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363593
Your team Nagios Charm developers is requested to review the proposed merge of
Review: Needs Fixing
First pass -- some inline comments, mostly nitpicking. TBD: review tests
Please also check flake8 config. Fwiw tox didn't install flake8 for me, also
the config checks for max-line-length=80. With the current setting of
max-line-length=80 getting a few errors. Otoh the
Xav Paice has proposed merging ~xavpaice/hw-health-charm:add_ipmi into
hw-health-charm:master.
Requested reviews:
Nagios Charm developers (nagios-charmers)
For more details, see:
https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363593
--
Your team Nagios Charm
12 matches
Mail list logo
