The proposal to merge ~xavpaice/nagios-charm:lp1827159 into nagios-charm:master
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/366741
--
Your team Nagios Charm developers is subscribed to
The proposal to merge ~xavpaice/nagios-charm:lp1827159 into nagios-charm:master
has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/366741
--
Your team Nagios Charm developers is subscribed to branch
Change successfully merged at revision 6f5e177f0f718478cbaaab85ab3c32f4ee55bf16
--
https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/366741
Your team Nagios Charm developers is subscribed to branch nagios-charm:master.
--
Mailing list:
Review: Approve
LGTM
--
https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/366741
Your team Nagios Charm developers is subscribed to branch nagios-charm:master.
--
Mailing list: https://launchpad.net/~nagios-charmers
Post to : nagios-charmers@lists.launchpad.net
Xav Paice has proposed merging ~xavpaice/nagios-charm:lp1827159 into
nagios-charm:master.
Commit message:
Add custom disk monitor for nagios host
Requested reviews:
James Hebden (ec0)
For more details, see:
https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/366741
--
This merge proposal is being monitored by mergebot. Change the status to
Approved to merge.
--
https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/366741
Your team Nagios Charm developers is subscribed to branch nagios-charm:master.
--
Mailing list:
Review: Needs Fixing
Just one comment on the name of the service, but other than that, the technical
aspects of the change make sense and LGTM.
Diff comments:
> diff --git a/hooks/templates/localhost_nagios2.cfg.tmpl
> b/hooks/templates/localhost_nagios2.cfg.tmpl
> index 3cd69e1..b5a6153
The proposal to merge ~xavpaice/nagios-charm:lp1827159 into nagios-charm:master
has been updated.
Commit message changed to:
Add custom disk monitor for nagios host
For more details, see:
https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/366740
--
Your team Nagios
8 matches
Mail list logo