Re: [Nagios-users] hostgroup with no members - Enhancement

2010-12-17 Thread Michael Friedrich
Original Message Subject: Re: [Nagios-users] hostgroup with no members - Enhancement From: Max Schubert m...@webwizarddesign.com To: Andreas Ericsson a...@op5.se, Nagios Users List nagios-users@lists.sourceforge.net Date: 2010-11-29 15:07 Thank you, Andreas - I actually really

Re: [Nagios-users] hostgroup with no members - Enhancement

2010-12-17 Thread Mathieu Gagné
On 12/17/10 4:02 PM, Ton Voon wrote: I didn't really follow this thread earlier, so bear with me with the questions: Does this have to be implemented as another variable? Why can't you always allow an empty hostgroup? (In the interests of keeping it simple) I agree with Ton. Why not

Re: [Nagios-users] hostgroup with no members - Enhancement

2010-11-29 Thread Andreas Ericsson
On 11/29/2010 04:27 AM, Max Schubert wrote: Hi, Long overdue and anxiously waited on by at least 3 people :), here is the patch, diffed against the CVS HEAD (as of tonight) revision of Nagios, with a documentation patch for configmain.html as well (as requested by Andreas): The option is

Re: [Nagios-users] hostgroup with no members - Enhancement

2010-11-29 Thread Max Schubert
Thank you, Andreas - I actually really enjoy writing tests and understand their value - will see if I can put a few in place using tap over the next week or so and update the patch with them. On 11/29/10, Andreas Ericsson a...@op5.se wrote: On 11/29/2010 09:20 AM, Andreas Ericsson wrote: This

Re: [Nagios-users] hostgroup with no members - Enhancement

2010-11-28 Thread Max Schubert
Hi, Long overdue and anxiously waited on by at least 3 people :), here is the patch, diffed against the CVS HEAD (as of tonight) revision of Nagios, with a documentation patch for configmain.html as well (as requested by Andreas): The option is now named allow_empty_hostgroup_assignment Thanks

Re: [Nagios-users] hostgroup with no members - Enhancement

2010-11-19 Thread Andreas Ericsson
On 11/18/2010 09:19 PM, Daniel Wittenberg wrote: I was curious if we were able to make any progress on getting this patch included? That depends on you, more or less. I'm just waiting for a rerolled one that's tested with latest CVS head and has the necessary documentation amendments. --

Re: [Nagios-users] hostgroup with no members - Enhancement

2010-11-19 Thread Daniel Wittenberg
Ericsson [mailto:a...@op5.se] Sent: Friday, November 19, 2010 3:17 AM To: Nagios Users List Cc: Daniel Wittenberg Subject: Re: [Nagios-users] hostgroup with no members - Enhancement On 11/18/2010 09:19 PM, Daniel Wittenberg wrote: I was curious if we were able to make any progress on getting

Re: [Nagios-users] hostgroup with no members - Enhancement

2010-11-19 Thread Max Schubert
Will try to get this done this weekend - sorry all, it is an irony to be working for a company that allows us to release code from work to open source and be so busy at the job that I rarely have time to do so :). My apologies for the delay - and thanks for your input, help, and feedback on the

Re: [Nagios-users] hostgroup with no members - Enhancement

2010-11-18 Thread Daniel Wittenberg
I was curious if we were able to make any progress on getting this patch included? Thanks! Dan -Original Message- From: Max Schubert [mailto:m...@webwizarddesign.com] Sent: Wednesday, November 03, 2010 7:04 AM To: Andreas Ericsson; Nagios Users List Subject: Re: [Nagios-users] hostgroup

Re: [Nagios-users] hostgroup with no members - Enhancement

2010-11-03 Thread Andreas Ericsson
On 11/02/2010 04:54 PM, Max Schubert wrote: allow_empty_hostgroups = 1 I'll take this, but rename the option to something more mnemonic, as empty hostgroups are already allowed and it's a bit ambiguous what it means. Any chance you could re-roll the patch against latest CVS head and include

Re: [Nagios-users] hostgroup with no members - Enhancement

2010-11-03 Thread Max Schubert
Will do my best to do this this week - if I don't get to it this week I will forget about it for sure, all the patches our team has done to make Nagios (some very very specific to our env) work for us will be available on our team github account; will do my best to get that updated this week as

Re: [Nagios-users] hostgroup with no members - Enhancement

2010-11-02 Thread Andreas Ericsson
On 11/01/2010 08:57 PM, Daniel Wittenberg wrote: I'd like to be able to create a hostgroup with no members assigned, but doesn't appear to work. Empty hostgroups work just fine. The check that says this is so starts at line 12516 in xdata/xodtemplate.c as of latest CVS/git. It's been like that

Re: [Nagios-users] hostgroup with no members - Enhancement

2010-11-02 Thread Daniel Wittenberg
: Andreas Ericsson [mailto:a...@op5.se] Sent: Tuesday, November 02, 2010 2:34 AM To: Nagios Users List Cc: Daniel Wittenberg Subject: Re: [Nagios-users] hostgroup with no members - Enhancement On 11/01/2010 08:57 PM, Daniel Wittenberg wrote: I'd like to be able to create a hostgroup with no members

Re: [Nagios-users] hostgroup with no members - Enhancement

2010-11-02 Thread Daniel Wittenberg
List Cc: Daniel Wittenberg Subject: Re: [Nagios-users] hostgroup with no members - Enhancement On 11/01/2010 08:57 PM, Daniel Wittenberg wrote: I'd like to be able to create a hostgroup with no members assigned, but doesn't appear to work. Empty hostgroups work just fine. The check that says

Re: [Nagios-users] hostgroup with no members - Enhancement

2010-11-02 Thread Andreas Ericsson
On 11/02/2010 02:59 PM, Daniel Wittenberg wrote: Ok, so this was a basic test, I have a GENERIC_PING check and it had the fake host in there and was working fine, as soon as I removed it (so no members defined): Error: Could not expand hostgroups and/or hosts specified in service (config

Re: [Nagios-users] hostgroup with no members - Enhancement

2010-11-02 Thread Daniel Wittenberg
-Original Message- From: Andreas Ericsson [mailto:a...@op5.se] Sent: Tuesday, November 02, 2010 9:10 AM To: Daniel Wittenberg Cc: Nagios Users List Subject: Re: [Nagios-users] hostgroup with no members - Enhancement On 11/02/2010 02:59 PM, Daniel Wittenberg wrote: Ok, so this was a basic

Re: [Nagios-users] hostgroup with no members - Enhancement

2010-11-02 Thread Andreas Ericsson
On 11/02/2010 03:16 PM, Daniel Wittenberg wrote: Basically because all the backend files are controlled via puppet, to a number of nagios servers, but the actual host assignments are controlled by third-party package. So, the base configs about all the services are pushed to every server, and

Re: [Nagios-users] hostgroup with no members - Enhancement

2010-11-02 Thread Daniel Wittenberg
Maybe it could just be considered a warning and not a fatal error? I can ignore warnings :) Dan -Original Message- From: Andreas Ericsson [mailto:a...@op5.se] Sent: Tuesday, November 02, 2010 9:43 AM To: Daniel Wittenberg Cc: Nagios Users List Subject: Re: [Nagios-users] hostgroup

Re: [Nagios-users] hostgroup with no members - Enhancement

2010-11-02 Thread Andreas Ericsson
On 11/02/2010 03:56 PM, Daniel Wittenberg wrote: Maybe it could just be considered a warning and not a fatal error? I can ignore warnings :) Yes and no. The code returns NULL for non-existing hostgroups referenced (which should remain an error) and NULL for existing hostgroups without member

Re: [Nagios-users] hostgroup with no members - Enhancement

2010-11-02 Thread Fredrik Barrud
Hi, I would also like to be able to create empty hostgroups with services assigned. The reason for this is that I've setup a nagios installation for a customer where a host is only member to one hostgroup to inherit services from other hostgroups, like all-windows-citrix-server and for a few

Re: [Nagios-users] hostgroup with no members - Enhancement

2010-11-02 Thread Max Schubert
On Tue, Nov 2, 2010 at 10:52 AM, Fredrik Barrud fred...@barrud.se wrote: Hi, I would also like to be able to create empty hostgroups with services assigned. The reason for this is that I've setup a nagios installation for a customer where a host is only member to one hostgroup to inherit

Re: [Nagios-users] hostgroup with no members - Enhancement

2010-11-02 Thread Max Schubert
To activate the downgrade from error to warning, put allow_empty_hostgroups = 1 in your nagios.cfg after compiling Nagios with the patch in place. - Max -- Nokia and ATT present the 2010 Calling All Innovators-North

Re: [Nagios-users] hostgroup with no members - Enhancement

2010-11-02 Thread Michael Friedrich
On 02.11.2010 16:50, Max Schubert wrote: We have a local patch to turn the error into a warning, patched against 3.2.0 - we needed this because we have customers who can use host - hostgroup - N related services mappings but we do not control their configs, we only define the global service

Re: [Nagios-users] hostgroup with no members - Enhancement

2010-11-02 Thread Andreas Ericsson
On 11/02/2010 04:54 PM, Max Schubert wrote: To activate the downgrade from error to warning, put allow_empty_hostgroups = 1 in your nagios.cfg after compiling Nagios with the patch in place. Neato. I'll apply and push it out tomorrow. -- Andreas Ericsson

Re: [Nagios-users] hostgroup with no members - Enhancement

2010-11-02 Thread Daniel Wittenberg
Very cool, look forward to using it! Dan -Original Message- From: Andreas Ericsson [mailto:a...@op5.se] Sent: Tuesday, November 02, 2010 12:56 PM To: Nagios Users List Subject: Re: [Nagios-users] hostgroup with no members - Enhancement On 11/02/2010 04:54 PM, Max Schubert wrote

[Nagios-users] hostgroup with no members - Enhancement

2010-11-01 Thread Daniel Wittenberg
I'd like to be able to create a hostgroup with no members assigned, but doesn't appear to work. The reason being is that I'm generating the host configs using a third-party tool, and it puts in that host file which hostgroups a host belong to. This works great, but there has to be at least 1

Re: [Nagios-users] hostgroup with no members - Enhancement

2010-11-01 Thread Enrico Zimol
On 1 November 2010 20:57, Daniel Wittenberg daniel.wittenberg.r...@statefarm.com wrote:   It would be nice if I could just put the hostgroups out there blank and then let the host definition completely populate what’s in there. Right now I have 1 fake host that is in every group, so I have one