Re: [nant-dev] Updates to MSBuild & VSNet Tasks

2011-08-07 Thread Ryan Boggs
After all the work that has been put into these VS.NET/MSBuild changes, they have been finally committed. Thanks for the hard work guys. Thanks, Ryan On Sun, Aug 7, 2011 at 3:25 PM, Ryan Boggs wrote: > Ah, good catches. I've made the changes in my tree and they are ready for > committing. > >

Re: [nant-dev] Updates to MSBuild & VSNet Tasks

2011-08-07 Thread Ryan Boggs
Ah, good catches. I've made the changes in my tree and they are ready for committing. If I don't hear anything else, all of these changes that Dominik, Martin, and myself have worked hard on will be committed tonight. Thanks everyone :) Ryan On Sun, Aug 7, 2011 at 1:33 PM, Dominik Guder wrote:

Re: [nant-dev] Updates to MSBuild & VSNet Tasks

2011-08-07 Thread Dominik Guder
Am 06.08.2011 21:12, schrieb Ryan Boggs: Hi, I'm thinking that at this point, since I believe I fixed the one or two things from the comments I received some months ago, I will commit these changes by end of day Monday unless I hear any objections before then. From there, I will perform some ni

Re: [nant-dev] Updates to MSBuild & VSNet Tasks

2011-08-07 Thread Dominik Guder
Hi Ryan, these changes are good rom my point of view. I have ony one minor thing what I can't test since I have difficulties to debug nant at the moment. MSBuildProject.cs within DetermineProductVersion line 279 if (_productVerNode != null) { Version _ver = new Vers

Re: [nant-dev] Updates to MSBuild & VSNet Tasks

2011-08-06 Thread Ryan Boggs
Hi, I'm thinking that at this point, since I believe I fixed the one or two things from the comments I received some months ago, I will commit these changes by end of day Monday unless I hear any objections before then. From there, I will perform some nightlys with these changes for public testin

Re: [nant-dev] Updates to MSBuild & VSNet Tasks

2011-07-29 Thread Ryan Boggs
Anyone had a change to review this yet? Does it look ok to commit? Please let me know. Thanks, Ryan On Fri, Jul 22, 2011 at 5:17 PM, Ryan Boggs wrote: > Updated diff to include changes to the DetermineProductVersion method. > > I decided that rather than relying on one element or attribute ta

Re: [nant-dev] Updates to MSBuild & VSNet Tasks

2011-07-22 Thread Ryan Boggs
Updated diff to include changes to the DetermineProductVersion method. I decided that rather than relying on one element or attribute tag, might as well check through them all. This method will now check for the ProductVersion element first for the msbuild project version. If that element doesn'

Re: [nant-dev] Updates to MSBuild & VSNet Tasks

2011-07-22 Thread Ryan Boggs
Hi, Thought I put in such a patch but it looks like I didn't yet. I will see about creating it today. Thanks, Ryan On Fri, Jul 22, 2011 at 2:54 AM, Martin Aliger wrote: > Yes, your solution is better. Depending on ProjectVersion was throwing odd > exceptions when it was not included (which hap

Re: [nant-dev] Updates to MSBuild & VSNet Tasks

2011-07-22 Thread Martin Aliger
Yes, your solution is better. Depending on ProjectVersion was throwing odd exceptions when it was not included (which happens even in VS for whatever reason): System.ArgumentException

Re: [nant-dev] Updates to MSBuild & VSNet Tasks

2011-06-28 Thread Ryan Boggs
m Core. All loaded types >>>> should be send into that (via TypeFactory). >>> Thanks, I take a look at this as well. >>>> >>>> Btw: I noticed, the solution providers from MSBuild assembly got VSNet >>>> namespace. Maybe it should be changed, for cla

Re: [nant-dev] Updates to MSBuild & VSNet Tasks

2011-06-23 Thread Ryan Boggs
ell. >>> >>> Btw: I noticed, the solution providers from MSBuild assembly got VSNet >>> namespace. Maybe it should be changed, for clarity. >> I tried switching this too but it didn't make a difference.  Unless >> this is really making a difference, I don&#x

Re: [nant-dev] Updates to MSBuild & VSNet Tasks

2011-06-21 Thread Ryan Boggs
t;> -Original Message----- >> From: Ryan Boggs [mailto:rmbo...@gmail.com] >> Sent: Thursday, June 16, 2011 3:37 PM >> To: Martin Aliger >> Cc: Dominik Guder; nant-developers@lists.sourceforge.net >> Subject: ***SPAM***BAR*** Re: [nant-dev] Updates to MSBuild & VSNet T

Re: [nant-dev] Updates to MSBuild & VSNet Tasks

2011-06-16 Thread Ryan Boggs
..@gmail.com] > Sent: Thursday, June 16, 2011 3:37 PM > To: Martin Aliger > Cc: Dominik Guder; nant-developers@lists.sourceforge.net > Subject: ***SPAM***BAR*** Re: [nant-dev] Updates to MSBuild & VSNet Tasks > Importance: Low > > Hi, > > Please see inline. > >

Re: [nant-dev] Updates to MSBuild & VSNet Tasks

2011-06-16 Thread Martin Aliger
-Original Message- From: Ryan Boggs [mailto:rmbo...@gmail.com] Sent: Thursday, June 16, 2011 3:37 PM To: Martin Aliger Cc: Dominik Guder; nant-developers@lists.sourceforge.net Subject: ***SPAM***BAR*** Re: [nant-dev] Updates to MSBuild & VSNet Tasks Importance: Low Hi, Please see in

Re: [nant-dev] Updates to MSBuild & VSNet Tasks

2011-06-16 Thread Ryan Boggs
Hi, Please see inline. Thanks, Ryan On Jun 16, 2011, at 2:39 AM, "Martin Aliger" wrote: >>> Hi Ryan, sln file handling is some kind of broken since VS2005. They >>> only work with 2002/2003. I would not spend to much time for now in >>> sln file handling in VS2005 and up. >> Eww, makes sense

Re: [nant-dev] Updates to MSBuild & VSNet Tasks

2011-06-15 Thread Ryan Boggs
Hi, Thanks for your reply. Inline comments below. On Wed, Jun 15, 2011 at 2:05 AM, Dominik Guder wrote: > Am 14.06.2011 05:14, schrieb Ryan Boggs: >> Hi, >> >> Just an update.  I'm having issues with trying to process solution >> files from .NET 2.0 and above with the solution task.  I'm still

Re: [nant-dev] Updates to MSBuild & VSNet Tasks

2011-06-15 Thread Dominik Guder
Am 14.06.2011 05:14, schrieb Ryan Boggs: > Hi, > > Just an update. I'm having issues with trying to process solution > files from .NET 2.0 and above with the solution task. I'm still > taking a look at it but it seems that the VS20** plugins in the > NAnt.MSBuild assembly are not being picked up

Re: [nant-dev] Updates to MSBuild & VSNet Tasks

2011-06-13 Thread Ryan Boggs
Hi, Just an update. I'm having issues with trying to process solution files from .NET 2.0 and above with the solution task. I'm still taking a look at it but it seems that the VS20** plugins in the NAnt.MSBuild assembly are not being picked up by the solution task. I'll keep checking... Thanks,

Re: [nant-dev] Updates to MSBuild & VSNet Tasks

2011-06-07 Thread Martin Aliger
Hi, >In addition I had issues to get solution task with included projects and without soultionfile property set running. Maybe I did something wrong. >(I used only vb projects) That should definitelly work. In fact, I would be less suprised if some problems arise in sln handling, since we are us

Re: [nant-dev] Updates to MSBuild & VSNet Tasks

2011-06-06 Thread Ryan Boggs
Hmm, On Mon, Jun 6, 2011 at 10:28 PM, Dominik Guder wrote: > Am 07.06.2011 01:53, schrieb Ryan Boggs: >> Hi, >> >> Martin seems good with the diff I posted.  Has anyone else reviewed it >> since I posted it last saturday?  The link to the patch is below. >> > > Yes, I did. > > One point it is not

Re: [nant-dev] Updates to MSBuild & VSNet Tasks

2011-06-06 Thread Dominik Guder
Am 07.06.2011 01:53, schrieb Ryan Boggs: > Hi, > > Martin seems good with the diff I posted. Has anyone else reviewed it > since I posted it last saturday? The link to the patch is below. > Yes, I did. One point it is not working with vb solutions, since PropertyGroup/ProductVersion exists but

Re: [nant-dev] Updates to MSBuild & VSNet Tasks

2011-06-06 Thread Ryan Boggs
Hi, Martin seems good with the diff I posted. Has anyone else reviewed it since I posted it last saturday? The link to the patch is below. https://sourceforge.net/tracker/?func=detail&aid=3311661&group_id=31650&atid=402870 Thanks, Ryan On Sat, Jun 4, 2011 at 4:23 PM, Ryan Boggs wrote: > Hi,

Re: [nant-dev] Updates

2011-05-11 Thread Ryan Boggs
Where did u post your changes originally? Thanks, Ryan On May 11, 2011, at 12:46 AM, "Martin Aliger" wrote: > I got same need and implemented that. But it never made its way to trunk > (posted atleast twice). > > I'll repost all mine changes today or tommorow. There are known problems > (wpf,

Re: [nant-dev] Updates

2011-05-11 Thread Martin Aliger
I got same need and implemented that. But it never made its way to trunk (posted atleast twice). I'll repost all mine changes today or tommorow. There are known problems (wpf, silverlight), but most of 4.0 solution stuff works well. Martin Aliger -Original Message- From: Dominik Guder [m

Re: [nant-dev] Updates

2011-05-10 Thread Dominik Guder
Am 06.05.2011 03:48, schrieb Ryan Boggs: > Looking forward to hearing your ideas. :) > So here they are :) Basically I comply with nant roadmap on http://sourceforge.net/apps/mediawiki/nant/index.php?title=Roadmap As you finished .Net 4.0 support I want to try to get nant running again on Teamc

Re: [nant-dev] Updates

2011-05-05 Thread Ryan Boggs
Looking forward to hearing your ideas. :) Thanks, Ryan On Thu, May 5, 2011 at 6:04 PM, Dominik Guder wrote: > Am 04.05.2011 07:19, schrieb Ryan Boggs: >> Hi, >> >> Just checking in real quick.  I just merged the branch I was working >> on into HEAD this evening.  If everything goes well, I shoul

Re: [nant-dev] Updates

2011-05-05 Thread Dominik Guder
Am 04.05.2011 07:19, schrieb Ryan Boggs: > Hi, > > Just checking in real quick. I just merged the branch I was working > on into HEAD this evening. If everything goes well, I should start > kicking out more nightly releases by this weekend, if not before. >> From there, I'll need to decide the fu

Re: [nant-dev] Updates to ResGenTask.cs...

2003-01-17 Thread Ian MacLean
Sorry Aaron. I didn't see your comment about not having diff. Ian Aaron, Can you please re-send this as a diff ? cvs diff -u. Its easier to review and apply in that format. Ian All, I made some changes to the ResGenTask.cs file that I would like reviewed and committed. I was having diffic

Re: [nant-dev] Updates to ResGenTask.cs...

2003-01-17 Thread Ian MacLean
Aaron, Can you please re-send this as a diff ? cvs diff -u. Its easier to review and apply in that format. Ian All, I made some changes to the ResGenTask.cs file that I would like reviewed and committed. I was having difficulty using this and having the task create my resource files with the