Re: [nant-dev] Updates to MSBuild VSNet Tasks

2011-07-22 Thread Martin Aliger
Yes, your solution is better. Depending on ProjectVersion was throwing odd exceptions when it was not included (which happens even in VS for whatever reason): internalerror typeSystem.ArgumentException/type message![CDATA[Version string portion was too short or too

Re: [nant-dev] Updates to MSBuild VSNet Tasks

2011-07-22 Thread Ryan Boggs
Hi, Thought I put in such a patch but it looks like I didn't yet. I will see about creating it today. Thanks, Ryan On Fri, Jul 22, 2011 at 2:54 AM, Martin Aliger martin_ali...@gordic.cz wrote: Yes, your solution is better. Depending on ProjectVersion was throwing odd exceptions when it was

Re: [nant-dev] Updates to MSBuild VSNet Tasks

2011-07-22 Thread Ryan Boggs
Updated diff to include changes to the DetermineProductVersion method. I decided that rather than relying on one element or attribute tag, might as well check through them all. This method will now check for the ProductVersion element first for the msbuild project version. If that element