Re: [nant-dev] Adding Validators

2002-09-30 Thread Ian MacLean
on't need. Ian >-Original Message- >From: Ian MacLean [mailto:[EMAIL PROTECTED]] >Sent: Monday, September 30, 2002 2:20 PM >To: Scott Hernandez >Cc: 'Barkley, Chris'; [EMAIL PROTECTED] >Subject: Re: [nant-dev] Adding Validators > > >I think some of this came out

RE: [nant-dev] Adding Validators

2002-09-30 Thread Barkley, Chris
: 'Barkley, Chris'; [EMAIL PROTECTED] Subject: Re: [nant-dev] Adding Validators I think some of this came out when InitializeAttributes was originally rewritten. As it stands we only have BooleanValidator and Int32Validator. In fact this line of code paramaters[0] = Convert.ChangeType

Re: [nant-dev] Adding Validators

2002-09-30 Thread Ian MacLean
I think some of this came out when InitializeAttributes was originally rewritten. As it stands we only have BooleanValidator and Int32Validator. In fact this line of code paramaters[0] = Convert.ChangeType(attrValue, propertyInfo.PropertyType); will throw an exception if attrValue cannont safe

RE: [nant-dev] Adding Validators

2002-09-30 Thread Shaw, Gerry
2 PM > To: Shaw, Gerry > Subject: RE: [nant-dev] Adding Validators > > > Gerry, > The final verdict after hours of debugging I have found that > the Validators are never called. I have put breakpoints in > all of them and ran scripts that contained tasks that had all >

RE: [nant-dev] Adding Validators

2002-09-30 Thread Scott Hernandez
I would call this feature missing a bug. It seems like we need to add some unit tests to check this so more features don't disappear. I looked in an old snapshot of nant (circa may 17th) and there is validation related code commented out there. It must have been removed from the file sometime aft

RE: [nant-dev] Adding Validators

2002-09-25 Thread Shaw, Gerry
> Do I need to update > any files to tell it that this new validator? To be honest Chris I don't know. I suggest you set a breakpoint on the BooleanValidator code and trace through it. I believe the code is in the Element.cs that will be of interest. Feel free to comment the BuildAttributeAtt