Re: RFR 8130888: Typos in nashorn sources [was Re: [PATCH] typos]

Hi, here's a lower-case review. Just one remark: in OptionTemplate, the comment should end in "... if none exists" instead of "... if non exists". Otherwise this looks good. Thank you, Ahmed! Funny: the diff for NativeFunction.java is empty in the Udiff view, but there is a patch. Apparently j

Re: [PATCH] javax,script.ScriptEngineFactory Typos

Dear all, Please find below a proposed patch based on jdk9/dev. Thanks, Ahmed diff -r b526c2584b4b src/java.scripting/share/classes/javax/script/ScriptEngineFactory.java --- a/src/java.scripting/share/classes/javax/script/ScriptEngineFactory.java Wed Jul 08 21:54:32 2015 -0400 +++ b/src/ja

RFR 8130888: Typos in nashorn sources [was Re: [PATCH] typos]

Hi, Please review http://cr.openjdk.java.net/~sundar/8130888/ for https://bugs.openjdk.java.net/browse/JDK-8130888 Hi Ahmed, No problem! Initial problems are normal :) Thanks for the contribution! -Sundar On Thursday 09 July 2015 10:10 PM, Ahmed Ashour wrote: Hi all, Apologies, but it see

Re: RFR(XXS): 8130862: let hg ignore TestNG ZIP file in Nashorn test library directory

+1 On Thursday 09 July 2015 08:42 PM, Michael Haupt wrote: Hi, please review and sponsor this trivial fix. RFE: https://bugs.openjdk.java.net/browse/JDK-8130862 Webrev: http://cr.openjdk.java.net/~mhaupt/8130862/webrev.00 It solely adds the TestNG ZIP file to .hgignore. Thanks, Michael

Re: RFR 8130734: Apply transformations found by netbeans Refactor->Inspect and transform menu

+1. > On 08 Jul 2015, at 13:38, A. Sundararajan > wrote: > > Updated: http://cr.openjdk.java.net/~sundar/8130734/webrev.01/ > > PropertyBind.staticReadOnly field should not be made final. > > - private static int staticReadOnly = 1230; > > as that tries various combinations of modifiers. i.e

RE: [PATCH] typos

Hi all, Apologies, but it seems the email web interface is not helpful to send plain text. Please find the blow patch, I hope you find it useful. Thanks, Ahmed diff -r 3cb11f4d617e buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ConstructorGenerator.java --- a/buildtools/nasgen/sr

Re: RFR(XXS): 8130862: let hg ignore TestNG ZIP file in Nashorn test library directory

+1 Am 2015-07-09 um 17:12 schrieb Michael Haupt: Hi, please review and sponsor this trivial fix. RFE: https://bugs.openjdk.java.net/browse/JDK-8130862 Webrev: http://cr.openjdk.java.net/~mhaupt/8130862/webrev.00 It solely adds the TestNG ZIP file to .hgignore. Thanks, Michael

RFR(XXS): 8130862: let hg ignore TestNG ZIP file in Nashorn test library directory

Hi, please review and sponsor this trivial fix. RFE: https://bugs.openjdk.java.net/browse/JDK-8130862 Webrev: http://cr.openjdk.java.net/~mhaupt/8130862/webrev.00 It solely adds the TestNG ZIP file to .hgignore. Thanks, Michael -- Dr. Michael Haupt | Principal Membe

Re: [PATCH] Delete testng.zip after extraction

Hi Ahmed, thanks for pointing this out; I'll add the file to .hgignore. https://bugs.openjdk.java.net/browse/JDK-8130862 BTW the -test-nosecurity target just completed happily for me without the ZIP file being around. It would help if you could indicate the nature of the problem you've encounte

Re: [PATCH] Delete testng.zip after extraction

Hi again, I would withdraw the below patch. Somehow the .zip is referenced by -test-nosecurity target, and I couldn't easily find where exactly. Ahmed From: Ahmed Ashour To: Nashorn-dev Sent: Thursday, July 9, 2015 11:32 AM Subject: [PATCH] Delete testng.zip after extraction Hi all,

[PATCH] Delete testng.zip after extraction

Hi all, As you know, the ant target 'get-testng' is meant to extract .jar file from .zip file from internet. However, it leaves the downloaded file 'testng-6.8.zip', which is not needed after the extraction. This affects the working project status (e.g. patch creation), as that file will be mark

Re: Build fails on Windows

Hi Ahmed, > Am 08.07.2015 um 19:51 schrieb Ahmed Ashour : > All test262parallel 11552 tests pass. thanks for confirming! > Noting that get-octane and get-sunspider wasn't able to be reached, although > of many times trial (behind a proxy, and SVN is correctly configured). > ... > get-octane: