Re: RFR 8134260: jjs in jre directory fails with "Could not find or load main class jdk.nashorn.tools.jjs.Main"

2015-08-25 Thread Marcus Lagergren
Copyright 2011, 2014 in gmk file. Otherwise +1 /M > On 25 Aug 2015, at 15:24, Sundararajan Athijegannathan > wrote: > > Hi, > > Please review http://cr.openjdk.java.net/~sundar/8134260/ for > https://bugs.openjdk.java.net/browse/JDK-8134260 > > jdk.nashorn.tools.jjs and jdk.internal.le sho

Re: RFR 8134260: jjs in jre directory fails with "Could not find or load main class jdk.nashorn.tools.jjs.Main"

2015-08-25 Thread Alan Bateman
On 25/08/2015 14:24, Sundararajan Athijegannathan wrote: Hi, Please review http://cr.openjdk.java.net/~sundar/8134260/ for https://bugs.openjdk.java.net/browse/JDK-8134260 jdk.nashorn.tools.jjs and jdk.internal.le should exist in jre's appmodules.jimage with this change and so jjs would work

Re: RFR 8134260: jjs in jre directory fails with "Could not find or load main class jdk.nashorn.tools.jjs.Main"

2015-08-25 Thread Erik Joelsson
Looks ok to me. /Erik On 2015-08-25 15:24, Sundararajan Athijegannathan wrote: Hi, Please review http://cr.openjdk.java.net/~sundar/8134260/ for https://bugs.openjdk.java.net/browse/JDK-8134260 jdk.nashorn.tools.jjs and jdk.internal.le should exist in jre's appmodules.jimage with this chan

RFR 8134260: jjs in jre directory fails with "Could not find or load main class jdk.nashorn.tools.jjs.Main"

2015-08-25 Thread Sundararajan Athijegannathan
Hi, Please review http://cr.openjdk.java.net/~sundar/8134260/ for https://bugs.openjdk.java.net/browse/JDK-8134260 jdk.nashorn.tools.jjs and jdk.internal.le should exist in jre's appmodules.jimage with this change and so jjs would work in JRE. Also, jjs launcher tool was created from wrong m

Re: RFR 8134397: Features that require AWT, swing should handle headless mode properly

2015-08-25 Thread Attila Szegedi
+1 > On Aug 25, 2015, at 1:25 PM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8134397/ for > https://bugs.openjdk.java.net/browse/JDK-8134397 > > Thanks, > -Sundar

Re: RFR 8134397: Features that require AWT, swing should handle headless mode properly

2015-08-25 Thread Hannes Wallnoefer
+1 Am 2015-08-25 um 13:25 schrieb Sundararajan Athijegannathan: Please review http://cr.openjdk.java.net/~sundar/8134397/ for https://bugs.openjdk.java.net/browse/JDK-8134397 Thanks, -Sundar

RFR 8134397: Features that require AWT, swing should handle headless mode properly

2015-08-25 Thread Sundararajan Athijegannathan
Please review http://cr.openjdk.java.net/~sundar/8134397/ for https://bugs.openjdk.java.net/browse/JDK-8134397 Thanks, -Sundar

Re: RFR 8134381: load completion should not use swing from non UI thread

2015-08-25 Thread Hannes Wallnoefer
+1 Am 2015-08-25 um 07:25 schrieb Sundararajan Athijegannathan: Please review http://cr.openjdk.java.net/~sundar/8134381/ for https://bugs.openjdk.java.net/browse/JDK-8134381 Thanks, -Sundar