Re: How to prevent built-in functions or objects to be overwritten?

2016-02-29 Thread Sundararajan Athijegannathan
You can use Object.defineProperty function [1], [2] to make properties non-writable and non-configurable (i.e., can't be written, can't be deleted or configured to make it writable again etc.) For example, the following Object.defineProperty(this, "quit", { writable: false, configurable:

How to prevent built-in functions or objects to be overwritten?

2016-02-29 Thread Trig Chen
I'm using nashorn engine in embedding mode and providing user a command line textbox to interactive with nashorn. It's fund that nashorn engine's built-in functions or objects such as quit, Java were overwritten by user's mistaken typing: quit=3; Java="Hello"; Is there a way to prevent user

Review request for JDK-8138906

2016-02-29 Thread Srinivas Dama
Hello All, Please review : Bug : https://bugs.openjdk.java.net/browse/JDK-8138906 Webrev : http://cr.openjdk.java.net/~sdama/8138906/webrev.01 Fix is to pick 'java' from specified JAVA_HOME folder, along with this, I have added some utility functions(can be added more) which can be used in all

Re: Review request for JDK-8150218: Autoconversion SAM adapters sometimes don't get privileges

2016-02-29 Thread Attila Szegedi
On Feb 29, 2016, at 9:38 AM, Michael Haupt wrote: > > Hi Attila, > >> Am 28.02.2016 um 04:37 schrieb Attila Szegedi : >> Please review JDK-8150218 "Autoconversion SAM adapters sometimes don't get >> privileges" at

Re: RFR(XXS): 8150814: correct package declaration in Nashorn test

2016-02-29 Thread Attila Szegedi
+1 > On Feb 29, 2016, at 9:12 AM, Michael Haupt wrote: > > Dear all, > > please review this very small fix. > Bug: https://bugs.openjdk.java.net/browse/JDK-8150814 > Webrev: http://cr.openjdk.java.net/~mhaupt/8150814/webrev.00/ > > Thanks, > > Michael > > -- > >

Re: Review request for JDK-8150218: Autoconversion SAM adapters sometimes don't get privileges

2016-02-29 Thread Sundararajan Athijegannathan
+1 On 2/28/2016 9:07 AM, Attila Szegedi wrote: > Please review JDK-8150218 "Autoconversion SAM adapters sometimes don't get > privileges" at for > > > Thanks, > Attila.

Re: RFR(XXS): 8150814: correct package declaration in Nashorn test

2016-02-29 Thread Sundararajan Athijegannathan
+1 On 2/29/2016 1:42 PM, Michael Haupt wrote: > Dear all, > > please review this very small fix. > Bug: https://bugs.openjdk.java.net/browse/JDK-8150814 > Webrev: http://cr.openjdk.java.net/~mhaupt/8150814/webrev.00/ > > Thanks, > > Michael >

Re: Review request for JDK-8150218: Autoconversion SAM adapters sometimes don't get privileges

2016-02-29 Thread Michael Haupt
Hi Attila, > Am 28.02.2016 um 04:37 schrieb Attila Szegedi : > Please review JDK-8150218 "Autoconversion SAM adapters sometimes don't get > privileges" at for >

RFR(XXS): 8150814: correct package declaration in Nashorn test

2016-02-29 Thread Michael Haupt
Dear all, please review this very small fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8150814 Webrev: http://cr.openjdk.java.net/~mhaupt/8150814/webrev.00/ Thanks, Michael -- Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax:

Re: RFR(S): 8148140: arguments are handled differently in apply for JS functions and AbstractJSObjects

2016-02-29 Thread Michael Haupt
Hi Attila, > Am 28.02.2016 um 04:05 schrieb Attila Szegedi : > Sorry, late to the party here, but it seems to me that there’s a discrepancy > between the path > and the > "package jdk.nashorn.internal.runtime.test" declaration it contains. whoa, thanks, Attila. Tracked in