Re: RFR: 8150219: ReferenceError in 1.8.0_72

I’ve uploaded a new webrev that reintroduces the Global.initscontext field instead of reusing the current context thread local so it will behave the same from all threads. Please review. http://cr.openjdk.java.net/~hannesw/8150219/webrev.01/ Thanks, Hannes > Am 14.06.2016 um 10:22 schrieb

Re: Share context/JS bindings

I prototyped the proposed change to the clear() method. It seems to work well and makes a lot of sense to me, so I filed a bug for it: https://bugs.openjdk.java.net/browse/JDK-8159589 I haven’t discussed this with the other team members yet, so let’s see what they think. Hannes > Am

Re: RFR:8158817

Hi Srini, „it self“ should be a single word in Math.ceil and Math.floor. Otherwise looks good. Hannes > Am 15.06.2016 um 13:21 schrieb Michael Haupt : > > Hi Srini, > > lower-case thumbs up, with these corrections: > * Math.ceil, Math.floor: ... returns argument it

Re: RFR:8158817

Hi Srini, lower-case thumbs up, with these corrections: * Math.ceil, Math.floor: ... returns argument it self ... -> ... returns argument itself ... * Math.random, Math.sin: insert space after comma Best, Michael > Am 15.06.2016 um 08:54 schrieb Srinivas Dama : > >

Re: Share context/JS bindings

Am 14.06.2016 um 22:09 schrieb Tony Zakula: Interesting. We use on global context and create a new engine context with each run. The initial compile of several scripts is over 100ms, but then we see that drop to under 10ms. The context creation seems to have very little overhead. We have not

RFR:8158817

Hi, Please review http://cr.openjdk.java.net/~sdama/8158817/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8158817 Regards, Srinivas