RE: RFR: 8156615:Catch parameter can be a BindingPattern in ES6 mode

Hi, Please review webrev: http://cr.openjdk.java.net/~sdama/8156615/webrev.03/ Bug : https://bugs.openjdk.java.net/browse/JDK-8156615 @Attila, Thank you for the comments. Regards, Srinivas -Original Message- From: Attila Szegedi [mailto:szege...@gmail.com] Sent: Thursday, November

Re: RFR: 8168049: Fix Performance of Lexer.isJSWhitespace

Nice, +1. > On 11 Nov 2016, at 12:44, Sundararajan Athijegannathan > wrote: > > +1 > > > On 11/11/2016 4:55 PM, Hannes Wallnöfer wrote: >> Please review: >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8168049 >> Webrev:

Re: RFR: 8168049: Fix Performance of Lexer.isJSWhitespace

+1 On 11/11/2016 4:55 PM, Hannes Wallnöfer wrote: > Please review: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8168049 > Webrev: http://cr.openjdk.java.net/~hannesw/8168049/webrev/ > > This improves parse time by 5 - 10% in most scripts I’ve looked at. > > Thanks, > Hannes

Re: Review request for JDK-8168373: don't emit conversions for symbols outside their lexical scope

+1 On 11/10/2016 5:50 PM, Attila Szegedi wrote: > 2nd review, anyone? Or can I go ahead with one? > > Attila. > >> On 08 Nov 2016, at 18:07, Hannes Wallnöfer >> wrote: >> >> +1 >> >> Thank for fixing this, Attila! >> >> Hannes >> >>> Am 08.11.2016 um 14:01 schrieb

RFR: 8168049: Fix Performance of Lexer.isJSWhitespace

Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8168049 Webrev: http://cr.openjdk.java.net/~hannesw/8168049/webrev/ This improves parse time by 5 - 10% in most scripts I’ve looked at. Thanks, Hannes