RE: RFR: 8151994 (test/script/basic/JDK-8141209.js fails)

2016-12-22 Thread Srinivas Dama
Hi, Please review http://cr.openjdk.java.net/~sdama/8151994/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8151994 Moved earlier fix to test/script/trusted directory. Regards, Srinivas -Original Message- From: Hannes Wallnöfer Sent: Wednesday, December 21, 2016 5:15 PM To:

Re: Review request for JDK-8171849: Collection and Queue conversions not prioritized for Arrays

2016-12-22 Thread Hannes Wallnöfer
+1 Thanks! Hannes > Am 22.12.2016 um 17:44 schrieb Jim Laskey (Oracle) : > > +1 > >> On Dec 22, 2016, at 12:32 PM, Attila Szegedi wrote: >> >> Please review JDK-8171849 "Collection and Queue conversions not prioritized >> for Arrays" at

Re: Review request for JDK-8171849: Collection and Queue conversions not prioritized for Arrays

2016-12-22 Thread Jim Laskey (Oracle)
+1 > On Dec 22, 2016, at 12:32 PM, Attila Szegedi wrote: > > Please review JDK-8171849 "Collection and Queue conversions not prioritized > for Arrays" at for > > >

Re: RFR: 8170977: SparseArrayData should not grow its underlying dense array data

2016-12-22 Thread Attila Szegedi
+1 > On 22 Dec 2016, at 16:15, Hannes Wallnöfer > wrote: > > Please review: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8170977 > Webrev: http://cr.openjdk.java.net/~hannesw/8170977/webrev/ > > With this we keep whatever is already allocated as dense array

Re: RFR: 8166187: Regression: NPE during reparse when using persistent code cache and optimistic types

2016-12-22 Thread Jim Laskey (Oracle)
+1 > On Dec 22, 2016, at 11:18 AM, Hannes Wallnöfer > wrote: > > Please review: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8166187 > Webrev: http://cr.openjdk.java.net/~hannesw/8166187/webrev/ > > It was actually the combination of having a

Re: RFR: 8170977: SparseArrayData should not grow its underlying dense array data

2016-12-22 Thread Jim Laskey (Oracle)
+1 > On Dec 22, 2016, at 11:15 AM, Hannes Wallnöfer > wrote: > > Please review: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8170977 > Webrev: http://cr.openjdk.java.net/~hannesw/8170977/webrev/ > > With this we keep whatever is already allocated as dense

RFR: 8166187: Regression: NPE during reparse when using persistent code cache and optimistic types

2016-12-22 Thread Hannes Wallnöfer
Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8166187 Webrev: http://cr.openjdk.java.net/~hannesw/8166187/webrev/ It was actually the combination of having a non-serialisable AST reference and not initialising the transient fields of nested functions that caused this error.