Hi Attila,
Thank you for the detailed review.
Regards,
Srinivas
-Original Message-
From: Attila Szegedi [mailto:szege...@gmail.com]
Sent: Thursday, March 02, 2017 9:01 PM
To: Srinivas Dama
Cc: Nashorn-dev
Subject: Re: RFR: 8156743: ES6 for..of should work for Java Maps and Sets
+1
Sent from my iPhone
> On Mar 2, 2017, at 10:36 AM, Srinivas Dama wrote:
>
> Hello,
>
> Please review http://cr.openjdk.java.net/~sdama/8156743/webrev.00/
> for https://bugs.openjdk.java.net/browse/JDK-8156743
>
> Regards,
> Srinivas
>
Quick comment:
File: ScriptRuntime.java
404 if (obj != null && obj instanceof Map) {
should just be
if (obj instanceof Map) {
-Sundar
On 02/03/17, 8:06 PM, Srinivas Dama wrote:
Hello,
Please review http://cr.openjdk.java.net/~sdama/8156743/webrev.00/
for
Contrary to the issue name, I don’t see anything for handling Set in the patch,
but I guess that’s because Set is a Collection and those already work?
As an aside… I was looking into your use of NativeJava.from to convert a Java
array to a NativeArray, and realized that we have at least 3 ways
Hello,
Please review http://cr.openjdk.java.net/~sdama/8156743/webrev.00/
for https://bugs.openjdk.java.net/browse/JDK-8156743
Regards,
Srinivas