Re: RFR: 8180727(Use jdk.editpad to replace jdk.nashorn.tools.jjs.EditPad duplicated class)

2017-07-25 Thread Hannes Wallnöfer
+1 > Am 25.07.2017 um 18:15 schrieb Jim Laskey (Oracle) : > > +1 > >> On Jul 25, 2017, at 10:54 AM, Srinivas Dama wrote: >> >> Hi, >> >> Please review http://cr.openjdk.java.net/~sdama/8180727/webrev.00/ >> >> for

Re: [10] RFR: 8184893: jdk8u152 b06 : issues with nashorn when running kraken benchmarks

2017-07-25 Thread Jim Laskey (Oracle)
+1 > On Jul 25, 2017, at 10:44 AM, Hannes Wallnöfer > wrote: > > Please review 8184893: jdk8u152 b06 : issues with nashorn when running kraken > benchmarks > > Kraken benchmark contains some files that invokes the Array constructor with > lots of number

Re: RFR: 8180727(Use jdk.editpad to replace jdk.nashorn.tools.jjs.EditPad duplicated class)

2017-07-25 Thread Jim Laskey (Oracle)
+1 > On Jul 25, 2017, at 10:54 AM, Srinivas Dama wrote: > > Hi, > > Please review http://cr.openjdk.java.net/~sdama/8180727/webrev.00/ > > for https://bugs.openjdk.java.net/browse/JDK-8180727 > > > > Regards, > > Srinivas

RE: [10] RFR: 8184893: jdk8u152 b06 : issues with nashorn when running kraken benchmarks

2017-07-25 Thread Srinivas Dama
Hi Hannes, Lower-case thumbs up. -Original Message- From: Hannes Wallnöfer Sent: Tuesday, July 25, 2017 7:14 PM To: Nashorn-dev Subject: [10] RFR: 8184893: jdk8u152 b06 : issues with nashorn when running kraken benchmarks Please review 8184893: jdk8u152 b06 : issues with nashorn when

RFR: 8180727(Use jdk.editpad to replace jdk.nashorn.tools.jjs.EditPad duplicated class)

2017-07-25 Thread Srinivas Dama
Hi, Please review http://cr.openjdk.java.net/~sdama/8180727/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8180727 Regards, Srinivas

[10] RFR: 8184893: jdk8u152 b06 : issues with nashorn when running kraken benchmarks

2017-07-25 Thread Hannes Wallnöfer
Please review 8184893: jdk8u152 b06 : issues with nashorn when running kraken benchmarks Kraken benchmark contains some files that invokes the Array constructor with lots of number literal arguments. We assume too low code footprint for these number literals in WeighNodes.java, resulting in