Re: RFR:8169233:LengthNotWritableFilter extraElements.remove(index) has no effect

2017-08-31 Thread Sundararajan Athijegannathan
+1 -Sundar On 01/09/17, 10:02 AM, Priya Lakshmi Muthuswamy wrote: Hi, Please review JDK-8169233 : LengthNotWritableFilter: extraElements.remove(index) has no effect JBS: https://bugs.openjdk.java.net/browse/JDK-8169233 webrev : http://cr.openjdk.java.net/~pmuthuswamy/8169233/webrev.00/

RFR:8169233:LengthNotWritableFilter extraElements.remove(index) has no effect

2017-08-31 Thread Priya Lakshmi Muthuswamy
Hi, Please review JDK-8169233 : LengthNotWritableFilter: extraElements.remove(index) has no effect JBS: https://bugs.openjdk.java.net/browse/JDK-8169233 webrev : http://cr.openjdk.java.net/~pmuthuswamy/8169233/webrev.00/ Thanks, Priya

Re: RFR:8177691:Labeled break in catch and finally works wrongly, when invoked through nashorn

2017-08-31 Thread Sundararajan Athijegannathan
+1 On 31/08/17, 8:21 PM, Hannes Wallnöfer wrote: +1 Am 29.08.2017 um 15:55 schrieb Srinivas Dama: Hi, Please review http://cr.openjdk.java.net/~sdama/8177691/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8177691 Regards, Srinivas

Re: RFR:8177691:Labeled break in catch and finally works wrongly, when invoked through nashorn

2017-08-31 Thread Hannes Wallnöfer
+1 > Am 29.08.2017 um 15:55 schrieb Srinivas Dama : > > Hi, > > > > Please review http://cr.openjdk.java.net/~sdama/8177691/webrev.00/ > > for https://bugs.openjdk.java.net/browse/JDK-8177691 > > > > Regards, > > Srinivas

Re: RFR:8177691:Labeled break in catch and finally works wrongly, when invoked through nashorn

2017-08-31 Thread Jim Laskey (Oracle)
+1 > On Aug 29, 2017, at 10:55 AM, Srinivas Dama wrote: > > Hi, > > > > Please review http://cr.openjdk.java.net/~sdama/8177691/webrev.00/ > > for https://bugs.openjdk.java.net/browse/JDK-8177691 > > > > Regards, > > Srinivas

Re: RFR:8073640:Nashorn scripting: here document with only whitespace gives error

2017-08-31 Thread Jim Laskey (Oracle)
+1 > On Aug 31, 2017, at 8:01 AM, Hannes Wallnöfer > wrote: > > +1 > > Does this change behaviour for non-empty strings? > > Hannes > >> Am 31.08.2017 um 10:51 schrieb Srinivas Dama : >> >> Hi, >> >> Please review

Re: RFR:8073640:Nashorn scripting: here document with only whitespace gives error

2017-08-31 Thread Hannes Wallnöfer
+1 Does this change behaviour for non-empty strings? Hannes > Am 31.08.2017 um 10:51 schrieb Srinivas Dama : > > Hi, > > Please review http://cr.openjdk.java.net/~sdama/8073640/webrev.00/ > for https://bugs.openjdk.java.net/browse/JDK-8073640 > > Regards, >

RFR:8073640:Nashorn scripting: here document with only whitespace gives error

2017-08-31 Thread Srinivas Dama
Hi, Please review http://cr.openjdk.java.net/~sdama/8073640/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8073640 Regards, srinivas