RFR 8188082: autoimports.js sample is broken

2017-09-27 Thread Sundararajan Athijegannathan
Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8188082 Webrev: http://cr.openjdk.java.net/~sundar/8188082/webrev.00/ PS. Piggybacking to push another sample to demonstrate the use of es6 tagged template literal to create a java object Thanks, -Sundar

Re: RFR: 8186815: Java.from has a bug, when element is ScriptObject

2017-09-27 Thread Jim Laskey (Oracle)
+1 > On Sep 27, 2017, at 11:44 AM, Hannes Wallnöfer > wrote: > > Please review: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8186815 > Webrev: http://cr.openjdk.java.net/~hannesw/8186815/webrev/ > > Thanks, > Hannes

Re: RFR: 8186815: Java.from has a bug, when element is ScriptObject

2017-09-27 Thread Sundararajan Athijegannathan
+1 -Sundar On 27/09/17, 8:14 PM, Hannes Wallnöfer wrote: Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8186815 Webrev: http://cr.openjdk.java.net/~hannesw/8186815/webrev/ Thanks, Hannes

RFR: 8186815: Java.from has a bug, when element is ScriptObject

2017-09-27 Thread Hannes Wallnöfer
Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8186815 Webrev: http://cr.openjdk.java.net/~hannesw/8186815/webrev/ Thanks, Hannes

Re: RFR 8188023: Avoid -source and -target javac options in nashorn ant compilation

2017-09-27 Thread Hannes Wallnöfer
+1 Hannes > Am 27.09.2017 um 14:07 schrieb Jim Laskey (Oracle) : > > +1 > >> On Sep 27, 2017, at 8:59 AM, Sundararajan Athijegannathan >> wrote: >> >> Please review. >> >> Bug:

Re: RFR 8188023: Avoid -source and -target javac options in nashorn ant compilation

2017-09-27 Thread Jim Laskey (Oracle)
+1 > On Sep 27, 2017, at 8:59 AM, Sundararajan Athijegannathan > wrote: > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8188023 > Webrev: http://cr.openjdk.java.net/~sundar/8188023/webrev.00/index.html > > Piggybacking to take

RFR 8188023: Avoid -source and -target javac options in nashorn ant compilation

2017-09-27 Thread Sundararajan Athijegannathan
Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8188023 Webrev: http://cr.openjdk.java.net/~sundar/8188023/webrev.00/index.html Piggybacking to take care of few javac warnings as well. Thanks, -Sundar

Re: RFR: 8187962: Optimistic types ignore JavaAdapter return types

2017-09-27 Thread Attila Szegedi
+1 > On 2017. Sep 26., at 19:05, Hannes Wallnöfer > wrote: > > Please review: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8187962 > Webrev: http://cr.openjdk.java.net/~hannesw/8187962/webrev/ > > Thanks, > Hannes

Re: RFR: JDK-8188012 Nashorn build targets version 9 source

2017-09-27 Thread David Holmes
On 27/09/2017 7:26 PM, Magnus Ihse Bursie wrote: On 2017-09-27 10:55, David Holmes wrote: On 27/09/2017 6:30 PM, Magnus Ihse Bursie wrote: The nashorn java code requires a somewhat convoluted compilation. As a result, we use a special java compiler setup, GENERATE_NEWBYTECODE_DEBUG. This

Re: RFR: JDK-8188012 Nashorn build targets version 9 source

2017-09-27 Thread Magnus Ihse Bursie
On 2017-09-27 10:55, David Holmes wrote: On 27/09/2017 6:30 PM, Magnus Ihse Bursie wrote: The nashorn java code requires a somewhat convoluted compilation. As a result, we use a special java compiler setup, GENERATE_NEWBYTECODE_DEBUG. This explicitly lists -source 9 -target 9, which

Re: RFR:8133623:JDK-8055034.js and JDK-8130127.js fail in nashorn nightly

2017-09-27 Thread Sundararajan Athijegannathan
+1 On 27/09/17, 2:34 PM, Hannes Wallnöfer wrote: +1 Hannes Am 27.09.2017 um 08:17 schrieb Priya Lakshmi Muthuswamy: Hi, --patch-module actually works and added it to back to the testcase. webrev :

Re: RFR:8133623:JDK-8055034.js and JDK-8130127.js fail in nashorn nightly

2017-09-27 Thread Hannes Wallnöfer
+1 Hannes > Am 27.09.2017 um 08:17 schrieb Priya Lakshmi Muthuswamy > : > > Hi, > > --patch-module actually works and added it to back to the testcase. > > webrev : http://cr.openjdk.java.net/~pmuthuswamy/8133623/webrev.01/ > > Thanks, > Priya > > On

Re: RFR: JDK-8188012 Nashorn build targets version 9 source

2017-09-27 Thread David Holmes
On 27/09/2017 6:30 PM, Magnus Ihse Bursie wrote: The nashorn java code requires a somewhat convoluted compilation. As a result, we use a special java compiler setup, GENERATE_NEWBYTECODE_DEBUG. This explicitly lists -source 9 -target 9, which generates this warning: warning: [options]

Re: RFR: JDK-8188012 Nashorn build targets version 9 source

2017-09-27 Thread dalibor topic
On 27.09.2017 10:30, Magnus Ihse Bursie wrote: The nashorn java code requires a somewhat convoluted compilation. As a result, we use a special java compiler setup, GENERATE_NEWBYTECODE_DEBUG. This explicitly lists -source 9 -target 9, which generates this warning: warning: [options]

RFR: JDK-8188012 Nashorn build targets version 9 source

2017-09-27 Thread Magnus Ihse Bursie
The nashorn java code requires a somewhat convoluted compilation. As a result, we use a special java compiler setup, GENERATE_NEWBYTECODE_DEBUG. This explicitly lists -source 9 -target 9, which generates this warning: warning: [options] bootstrap class path not set in conjunction with

Re: RFR:8133623:JDK-8055034.js and JDK-8130127.js fail in nashorn nightly

2017-09-27 Thread Priya Lakshmi Muthuswamy
Hi, --patch-module actually works and added it to back to the testcase. webrev : http://cr.openjdk.java.net/~pmuthuswamy/8133623/webrev.01/ Thanks, Priya On 9/25/2017 11:17 AM, Priya Lakshmi Muthuswamy wrote: Hi, Please review JDK-8133623 : JDK-8055034.js and JDK-8130127.js fail in nashorn