RFR 8180274: Fix links in nashorn documentation

2017-09-28 Thread Sundararajan Athijegannathan
Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8180274 Webrev: http://cr.openjdk.java.net/~sundar/8180274/webrev.00/ Thanks, -Sundar

Re: RFR 8188098: NPE in SimpleTreeVisitorES6 visitor when parsing a tagged template literal

2017-09-28 Thread Jim Laskey (Oracle)
+1 > On Sep 28, 2017, at 1:38 PM, Sundararajan Athijegannathan > wrote: > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8188098 > Webrev: http://cr.openjdk.java.net/~sundar/8188098/webrev.00/ > > Thanks, > -Sundar

Re: RFR 8188098: NPE in SimpleTreeVisitorES6 visitor when parsing a tagged template literal

2017-09-28 Thread Hannes Wallnöfer
+1, good catch! Hannes > Am 28.09.2017 um 18:38 schrieb Sundararajan Athijegannathan > : > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8188098 > Webrev: http://cr.openjdk.java.net/~sundar/8188098/webrev.00/ > > Thanks, > -Sundar

Re: RFR 8188082: autoimports.js sample is broken

2017-09-28 Thread Jim Laskey (Oracle)
+1 > On Sep 28, 2017, at 2:37 AM, Sundararajan Athijegannathan > wrote: > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8188082 > Webrev: http://cr.openjdk.java.net/~sundar/8188082/webrev.00/ > > PS. Piggybacking to push another

Re: RFR 8188082: autoimports.js sample is broken

2017-09-28 Thread Hannes Wallnöfer
+1 That tagged literal demo is nifty! Hannes > Am 28.09.2017 um 07:37 schrieb Sundararajan Athijegannathan > : > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8188082 > Webrev: http://cr.openjdk.java.net/~sundar/8188082/webrev.00/