Re: RFR [11]: 8194985: JavaAdapterBytecodeGenerator passes invalid type descriptor to ASM

2018-01-12 Thread Hannes Wallnöfer
Actually the old implementation was a bit careless, checking just the first character in a switch statement for primitive and reference types, and then creating a *method* type in the default case, which just happened to work by chance for our checkcast operation. The way it is now is

Re: RFR [11]: 8194985: JavaAdapterBytecodeGenerator passes invalid type descriptor to ASM

2018-01-12 Thread Attila Szegedi
+1 That’s a weird thing to make stricter. I guess in anticipation of value types which will use something other than L it can’t just substitute L anymore for anything that’s not a known primitive type name. Attila. > On 2018. Jan 12., at 11:08, Sundararajan Athijegannathan >

Re: RFR [11]: 8194985: JavaAdapterBytecodeGenerator passes invalid type descriptor to ASM

2018-01-12 Thread Sundararajan Athijegannathan
+1 -Sundar On 12/01/18, 2:56 PM, Hannes Wallnöfer wrote: Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8194985 Webrev: http://cr.openjdk.java.net/~hannesw/8194985/webrev.00/ Thanks, Hannes

RFR [11]: 8194985: JavaAdapterBytecodeGenerator passes invalid type descriptor to ASM

2018-01-12 Thread Hannes Wallnöfer
Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8194985 Webrev: http://cr.openjdk.java.net/~hannesw/8194985/webrev.00/ Thanks, Hannes