That should have been "do I miss something here?" :)
-Sundar
On 01/12/18, 11:43 AM, Sundararajan Athijegannathan wrote:
Class.getClasses() javadoc does not mention anything about order of
classes returned.
https://docs.oracle.com/javase/10/docs/api/java/lang/Class.html#getClasses()
Do we
Class.getClasses() javadoc does not mention anything about order of
classes returned.
https://docs.oracle.com/javase/10/docs/api/java/lang/Class.html#getClasses()
Do we need a check using Class.getDeclaringClass() or do I something here?
Thanks,
-Sundar
On 30/11/18, 4:44 PM, Attila Szegedi
Am 30.11.2018 um 14:04 schrieb Jim Laskey :
>
> +1
>
> too bad you have to hardcode the version
12 docs aren’t in their final place, and who knows if they’ll change the URL
scheme again :)
Thanks!
Hannes
>> On Nov 30, 2018, at 6:58 AM, Hannes Wallnöfer
>> wrote:
>>
>> Please review:
>>
On 30.11.2018 04:10, Robert Field wrote:
Nit: Why are the hyphens in the comments of AnsiWriter.java changed to
unicode?
These were unicode hyphens (–), not ordinary hyphens (-). I could have
replace them with ordinary hyphens, but opted to keeping the semantics
the same by using a unicode
+1
too bad you have to hardcode the version
> On Nov 30, 2018, at 6:58 AM, Hannes Wallnöfer
> wrote:
>
> Please review:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8214525
> Webrev: http://cr.openjdk.java.net/~hannesw/8214525/webrev.00/
>
> This enables gzip encoding for the YUI
+1
> On Nov 29, 2018, at 1:01 PM, Hannes Wallnöfer
> wrote:
>
> Please review:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8210943
> Webrev: http://cr.openjdk.java.net/~hannesw/8210943/webrev.00/
>
> AccessibleMembersLookup#lookupAccessibleMembers adds all nested classes
> returned
+1
> On 2018. Nov 30., at 11:58, Hannes Wallnöfer
> wrote:
>
> Please review:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8214525
> Webrev: http://cr.openjdk.java.net/~hannesw/8214525/webrev.00/
>
> This enables gzip encoding for the YUI download and switches javadoc tasks to
>
+1. Thanks for fixing this.
> On 2018. Nov 29., at 18:01, Hannes Wallnöfer
> wrote:
>
> Please review:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8210943
> Webrev: http://cr.openjdk.java.net/~hannesw/8210943/webrev.00/
>
> AccessibleMembersLookup#lookupAccessibleMembers adds all
Please review:
Bug: https://bugs.openjdk.java.net/browse/JDK-8214525
Webrev: http://cr.openjdk.java.net/~hannesw/8214525/webrev.00/
This enables gzip encoding for the YUI download and switches javadoc tasks to
modularized version of -linkoffline.
Thanks,
Hannes