CC'ing nashorn-dev.
-Sundar
On 05/12/18, 10:48 PM, Jan Lahoda wrote:
Hi Robert,
On 4.12.2018 23:59, Robert Field wrote:
I saw no issues with JShell tool and test portions of the webrev. I did
not review the nashorn changes.
Thanks for looking at this!
Testing it: editing multi-line
+1
> On 2018. Dec 5., at 15:33, Hannes Wallnöfer
> wrote:
>
> Please review:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8214795
> Webrev: http://cr.openjdk.java.net/~hannesw/8214795/webrev.00/
>
> This is to make sure we use the right inner classes regardless of the order
> of
This code is ultimately invoked from BeanLinker constructor, so always on a
single thread; there’s no race here. putIfAbsent was used here previously
solely for its effect of not replacing existing mappings, not because of its
atomicity.
Attila.
> On 2018. Dec 5., at 15:45, Jim Laskey wrote:
Wouldn’t you still use innerClasses.putIfAbsent in case there is a race?
> On Dec 5, 2018, at 10:33 AM, Hannes Wallnöfer
> wrote:
>
> Please review:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8214795
> Webrev: http://cr.openjdk.java.net/~hannesw/8214795/webrev.00/
>
> This is to make
Looks good.
-Sundar
On 05/12/18, 8:03 PM, Hannes Wallnöfer wrote:
Please review:
Bug: https://bugs.openjdk.java.net/browse/JDK-8214795
Webrev: http://cr.openjdk.java.net/~hannesw/8214795/webrev.00/
This is to make sure we use the right inner classes regardless of the order of
classes
Looks good
-Sundar
On 05/12/18, 8:03 PM, Hannes Wallnöfer wrote:
Please review:
Bug: https://bugs.openjdk.java.net/browse/JDK-8214795
Webrev: http://cr.openjdk.java.net/~hannesw/8214795/webrev.00/
This is to make sure we use the right inner classes regardless of the order of
classes
Please review:
Bug: https://bugs.openjdk.java.net/browse/JDK-8214795
Webrev: http://cr.openjdk.java.net/~hannesw/8214795/webrev.00/
This is to make sure we use the right inner classes regardless of the order of
classes returned by Class.getClasses().
Thanks,
Hannes
