Re: RFR: JDK-8214491: Upgrade to JLine 3.9.0

Thanks for fixing! Interactive mode manual testing is fine - tab completion, multi-line edit, built-in/external editor, history object all seem fine. +1 Thanks, -Sundar On 10/12/18, 6:33 PM, Jan Lahoda wrote: Thanks for testing Sundar! I've tried to update the jjs completion handling to

Re: RFR: JDK-8214491: Upgrade to JLine 3.9.0

Thanks for testing Sundar! I've tried to update the jjs completion handling to fix this problem here: http://cr.openjdk.java.net/~jlahoda/8214491/webrev.05/ Delta from previous patch: http://cr.openjdk.java.net/~jlahoda/8214491/webrev.delta.04.05/ What do you think? Thanks, Jan On

Re: RFR: JDK-8214491: Upgrade to JLine 3.9.0

Hi Jan, Tests are fine. Because there are not many UI automated tests for jjs, I tried to manually test few features. Tab-completion seems to be messed up. Only top-level completion seems to work. Property/method completion and inside multi-line method etc. don't seem to work. Thanks,

Re: RFR: JDK-8214491: Upgrade to JLine 3.9.0

Hi Sundar, Thanks for finding the problem! I was running tier1-3 tests, but seems these are not there. Seems the problem is how JLine(3) handles "dumb" terminals, it probably does not affect interactive use. So, adjusting the expected output should hopefully be OK. Updated patch: