Re: RFR: JDK-8214491: Upgrade to JLine 3.9.0

2018-12-09 Thread Robert Field
Thumbs up! -Robert On 12/9/18 2:45 PM, Jan Lahoda wrote: On 9.12.2018 16:40, Robert Field wrote: Ok. Go ahead and incorporate the text. I'll make a separate bug to sync the representation of keys in the other help entries. An updated patch (with your text): http://cr.openjdk.java.net

Re: RFR: JDK-8214491: Upgrade to JLine 3.9.0

2018-12-09 Thread Robert Field
Ok. Go ahead and incorporate the text. I'll make a separate bug to sync the representation of keys in the other help entries. Robert On December 9, 2018 6:36:26 AM Jan Lahoda wrote: Hi Robert, On 9.12.2018 02:40, Robert Field wrote: OK, here is my thinking on a /help keys entry. Note

Re: RFR: JDK-8214491: Upgrade to JLine 3.9.0

2018-12-08 Thread Robert Field
an Lahoda wrote: On 8.12.2018 20:39, Robert Field wrote: Thanks for updating. Good to have /help for line editing keys, however:    (1) The supported keys should be listed without requiring that the user knows or looks-up readline. More so, since only some readline keys are supposed.  

Re: RFR: JDK-8214491: Upgrade to JLine 3.9.0

2018-12-08 Thread Robert Field
On 12/8/18 11:47 AM, Jan Lahoda wrote: On 8.12.2018 20:39, Robert Field wrote: Thanks for updating. Good to have /help for line editing keys, however:    (1) The supported keys should be listed without requiring that the user knows or looks-up readline. More so, since only some readline keys

Re: RFR 8166183: jshell tool: on return from Ctrl-Z, garbage on screen, dies with Ctrl-C

2016-09-30 Thread Robert Field
Thumbs up on langtools and JDK. Thanks! Great to have this. Robert On September 30, 2016 2:50:46 AM Jan Lahoda wrote: Hello, When jshell or jjs are suspended and resumed, the terminal is reset to un-raw/cooked mode and jline editing is not working properly (as