Re: RFR: 8184239(Fix broken nashorn/samples)

2017-07-12 Thread Sundararajan Athijegannathan
To: Srinivas Dama Cc: Nashorn-Dev Subject: Re: RFR: 8184239(Fix broken nashorn/samples) +1 On Jul 12, 2017, at 6:00 AM, Srinivas Dama<srinivas.d...@oracle.com> wrote: Hi, Please review http://cr.openjdk.java.net/~sdama/8184239/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8

Re: RFR: 8184239(Fix broken nashorn/samples)

2017-07-12 Thread Jim Laskey (Oracle)
riginal Message- > From: Jim Laskey (Oracle) > Sent: Wednesday, July 12, 2017 5:34 PM > To: Srinivas Dama > Cc: Nashorn-Dev > Subject: Re: RFR: 8184239(Fix broken nashorn/samples) > > +1 > >> On Jul 12, 2017, at 6:00 AM, Srinivas Dama <srinivas.d...@oracle.com&g

RE: RFR: 8184239(Fix broken nashorn/samples)

2017-07-12 Thread Srinivas Dama
: 8184239(Fix broken nashorn/samples) +1 > On Jul 12, 2017, at 6:00 AM, Srinivas Dama <srinivas.d...@oracle.com> wrote: > > Hi, > > Please review http://cr.openjdk.java.net/~sdama/8184239/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8184239 > > Regards, > Srinivas

Re: RFR: 8184239(Fix broken nashorn/samples)

2017-07-12 Thread Jim Laskey (Oracle)
+1 > On Jul 12, 2017, at 6:00 AM, Srinivas Dama wrote: > > Hi, > > Please review http://cr.openjdk.java.net/~sdama/8184239/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8184239 > > Regards, > Srinivas

Re: RFR: 8184239(Fix broken nashorn/samples)

2017-07-12 Thread Hannes Wallnöfer
+1 Hannes > Am 12.07.2017 um 11:10 schrieb Sundararajan Athijegannathan > : > > +1 > > -Sundar > > On 12/07/17, 2:30 PM, Srinivas Dama wrote: >> Hi, >> >> Please review http://cr.openjdk.java.net/~sdama/8184239/webrev.00/ for >>

Re: RFR: 8184239(Fix broken nashorn/samples)

2017-07-12 Thread Sundararajan Athijegannathan
+1 -Sundar On 12/07/17, 2:30 PM, Srinivas Dama wrote: Hi, Please review http://cr.openjdk.java.net/~sdama/8184239/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8184239 Regards, Srinivas

RFR: 8184239(Fix broken nashorn/samples)

2017-07-12 Thread Srinivas Dama
Hi, Please review http://cr.openjdk.java.net/~sdama/8184239/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8184239 Regards, Srinivas