a.net/~sdama/8184241/webrev.02/
>
> Regards,
> Srinivas
>
> -Original Message-
> From: Hannes Wallnöfer
> Sent: Wednesday, July 19, 2017 2:51 PM
> To: Srinivas Dama
> Cc: Nashorn-Dev
> Subject: Re: RFR: 8184241(Fix nashorn/samples/filebrowser.js)
>
>
Forgot. +1
> On Jul 19, 2017, at 5:45 AM, Srinivas Dama wrote:
>
> Hi,
>
> Please review http://cr.openjdk.java.net/~sdama/8184241/webrev.00/ for
> https://bugs.openjdk.java.net/browse/JDK-8184241.
>
> Regards,
> Srinivas
Dama
Cc: Nashorn-Dev
Subject: Re: RFR: 8184241(Fix nashorn/samples/filebrowser.js)
Hi Srini,
The fix looks good, but what for is the arguments handling in the test?
Also, I would prefer to use our own base class (constructor must invoke
overridable method, what if TreeItem is refactored
Hi Srini,
The fix looks good, but what for is the arguments handling in the test?
Also, I would prefer to use our own base class (constructor must invoke
overridable method, what if TreeItem is refactored in the future?)
Hannes
> Am 19.07.2017 um 10:45 schrieb Srinivas Dama
Hi,
Please review http://cr.openjdk.java.net/~sdama/8184241/webrev.00/ for
https://bugs.openjdk.java.net/browse/JDK-8184241.
Regards,
Srinivas