Re: RFR: JDK-8137281: OutOfMemoryError with large numeric keys in JSON.parse

2015-10-05 Thread Marcus Lagergren
Happy with that. +1 /M > On 05 Oct 2015, at 09:43, Hannes Wallnoefer > wrote: > > Thanks Marcus. > > Actually the lower threshold does not affect any script in Octane or > Sunspider. When you set it so low that it starts being used more it really > hurts performance, but 1 million is still

Re: RFR: JDK-8137281: OutOfMemoryError with large numeric keys in JSON.parse

2015-10-05 Thread Hannes Wallnoefer
Thanks Marcus. Actually the lower threshold does not affect any script in Octane or Sunspider. When you set it so low that it starts being used more it really hurts performance, but 1 million is still pretty high while allowing us to keep a few of these in memory at a time. Hannes Am 2015-

Re: RFR: JDK-8137281: OutOfMemoryError with large numeric keys in JSON.parse

2015-10-05 Thread Marcus Lagergren
+1. No regressions everywhere on e.g. Octane? I have a feeling we bumped that buffer up to 8 megs for performance reasons. For the general case, this is of course way too much. /M > On 02 Oct 2015, at 13:08, Hannes Wallnoefer > wrote: > > Please review JDK-8137281: OutOfMemoryError with larg

Re: RFR: JDK-8137281: OutOfMemoryError with large numeric keys in JSON.parse

2015-10-02 Thread Attila Szegedi
+1 > On Oct 2, 2015, at 1:08 PM, Hannes Wallnoefer > wrote: > > Please review JDK-8137281: OutOfMemoryError with large numeric keys in > JSON.parse: > > http://cr.openjdk.java.net/~hannesw/8137281/webrev/ > > Thanks, > Hannes

Re: RFR: JDK-8137281: OutOfMemoryError with large numeric keys in JSON.parse

2015-10-02 Thread Michael Haupt
Hi Hannes, lower-case thumbs up. Best, Michael > Am 02.10.2015 um 13:08 schrieb Hannes Wallnoefer > : > > Please review JDK-8137281: OutOfMemoryError with large numeric keys in > JSON.parse: > > http://cr.openjdk.java.net/~hannesw/8137281/webrev/ > > Thanks, > Hannes --

RFR: JDK-8137281: OutOfMemoryError with large numeric keys in JSON.parse

2015-10-02 Thread Hannes Wallnoefer
Please review JDK-8137281: OutOfMemoryError with large numeric keys in JSON.parse: http://cr.openjdk.java.net/~hannesw/8137281/webrev/ Thanks, Hannes