Re: RFR:8186180:Symbol.__proto__ results in error with format string placeholder

2017-09-22 Thread Hannes Wallnöfer
+1 Hannes > Am 22.09.2017 um 08:41 schrieb Sundararajan Athijegannathan > : > > +1 > > -Sundar > > On 22/09/17, 11:58 AM, Priya Lakshmi Muthuswamy wrote: >> Moved the changes to jdk10/master repo. >> >> webrev : http://cr.openjdk.java.net/~pmuthuswamy/8186180/webrev.02/ >> >> Thanks, >> Pr

Re: RFR:8186180:Symbol.__proto__ results in error with format string placeholder

2017-09-21 Thread Sundararajan Athijegannathan
+1 -Sundar On 22/09/17, 11:58 AM, Priya Lakshmi Muthuswamy wrote: Moved the changes to jdk10/master repo. webrev : http://cr.openjdk.java.net/~pmuthuswamy/8186180/webrev.02/ Thanks, Priya On 9/7/2017 2:07 PM, Sundararajan Athijegannathan wrote: +1 On 07/09/17, 2:02 PM, Priya Lakshmi Muthus

Re: RFR:8186180:Symbol.__proto__ results in error with format string placeholder

2017-09-21 Thread Priya Lakshmi Muthuswamy
Moved the changes to jdk10/master repo. webrev : http://cr.openjdk.java.net/~pmuthuswamy/8186180/webrev.02/ Thanks, Priya On 9/7/2017 2:07 PM, Sundararajan Athijegannathan wrote: +1 On 07/09/17, 2:02 PM, Priya Lakshmi Muthuswamy wrote: Updated the test. Revised patch : http://cr.openjdk.ja

Re: RFR:8186180:Symbol.__proto__ results in error with format string placeholder

2017-09-07 Thread Sundararajan Athijegannathan
+1 On 07/09/17, 2:02 PM, Priya Lakshmi Muthuswamy wrote: Updated the test. Revised patch : http://cr.openjdk.java.net/~pmuthuswamy/8186180/webrev.01/ Thanks, Priya On 9/7/2017 1:49 PM, Sundararajan Athijegannathan wrote: The formatting of test can be improved - whitespace around "{", new li

Re: RFR:8186180:Symbol.__proto__ results in error with format string placeholder

2017-09-07 Thread Priya Lakshmi Muthuswamy
Updated the test. Revised patch : http://cr.openjdk.java.net/~pmuthuswamy/8186180/webrev.01/ Thanks, Priya On 9/7/2017 1:49 PM, Sundararajan Athijegannathan wrote: The formatting of test can be improved - whitespace around "{", new line chars between lines etc. +1 otherwise. -Sundar On 07/0

Re: RFR:8186180:Symbol.__proto__ results in error with format string placeholder

2017-09-07 Thread Sundararajan Athijegannathan
The formatting of test can be improved - whitespace around "{", new line chars between lines etc. +1 otherwise. -Sundar On 07/09/17, 9:09 AM, Priya Lakshmi Muthuswamy wrote: Hi, Please review JDK-8186180 : Symbol.__proto__ results in error with format string placeholder JBS: https://bugs.

Re: RFR:8186180:Symbol.__proto__ results in error with format string placeholder

2017-09-07 Thread Hannes Wallnöfer
+1 Hannes > Am 07.09.2017 um 05:39 schrieb Priya Lakshmi Muthuswamy > : > > Hi, > > Please review JDK-8186180 : Symbol.__proto__ results in error with format > string placeholder > > JBS: https://bugs.openjdk.java.net/browse/JDK-8186180 > webrev: http://cr.openjdk.java.net/~pmuthuswamy/81861

RFR:8186180:Symbol.__proto__ results in error with format string placeholder

2017-09-06 Thread Priya Lakshmi Muthuswamy
Hi, Please review JDK-8186180 : Symbol.__proto__ results in error with format string placeholder JBS: https://bugs.openjdk.java.net/browse/JDK-8186180 webrev: http://cr.openjdk.java.net/~pmuthuswamy/8186180/webrev.00/ Thanks, Priya