Re: RFR 8160141: removed deprecated method calls in nashorn code

Hi, Sorry I pushed with 2 reviews from Hannes and Michael. I'll take care of this cleanup in a later fix. Thanks, -Sundar On 6/23/2016 12:49 PM, Attila Szegedi wrote: > A minor point: the usual idiom we use for rethrowing RuntimeException is > > } catch(final RuntimeException e) { > throw e;

Re: RFR 8160141: removed deprecated method calls in nashorn code

A minor point: the usual idiom we use for rethrowing RuntimeException is } catch(final RuntimeException e) { throw e; } catch(final Exception e) { throw new RuntimeException(e); } instead of what you did in Global.java with an "if" in the "catch" +1 other than that. Attila. On Thu, Jun 23

Re: RFR 8160141: removed deprecated method calls in nashorn code

Looks good! Hannes > Am 23.06.2016 um 08:11 schrieb Michael Haupt : > > Hi Sundar, > > thumbs up. > > Best, > > Michael > >> Am 23.06.2016 um 06:28 schrieb Sundararajan Athijegannathan >> : >> >> Please review http://cr.openjdk.java.net/~sundar/8160141/webrev.00/ for >> https://bugs.openjd

Re: RFR 8160141: removed deprecated method calls in nashorn code

Hi Sundar, thumbs up. Best, Michael > Am 23.06.2016 um 06:28 schrieb Sundararajan Athijegannathan > : > > Please review http://cr.openjdk.java.net/~sundar/8160141/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8160141 > > Thanks, > > Sundar > -- Dr.

RFR 8160141: removed deprecated method calls in nashorn code

Please review http://cr.openjdk.java.net/~sundar/8160141/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8160141 Thanks, Sundar