Re: Review request for JDK-8141407: Wrong evaluation of a != a when a = NaN

2015-11-23 Thread Attila Szegedi
+1. As you correctly point out, this was caused by JDK-8043608. Strangely enough, I fixed the NaN case for strictEquals() with JDK-8044786, but I remember reasoning that it wasn’t an issue for equals(). Apparently, that was wrong… Attila. > On Nov 23, 2015, at 3:35 PM, Hannes Wallnöfer wrote:

Re: Review request for JDK-8141407: Wrong evaluation of a != a when a = NaN

2015-11-23 Thread Hannes Wallnoefer
Am 2015-11-23 um 16:05 schrieb Attila Szegedi: +1. As you correctly point out, this was caused by JDK-8043608. Strangely enough, I fixed the NaN case for strictEquals() with JDK-8044786, but I remember reasoning that it wasn’t an issue for equals(). Apparently, that was wrong… The reason may

Re: Review request for JDK-8141407: Wrong evaluation of a != a when a = NaN

2015-11-23 Thread Sundararajan Athijegannathan
+1 -Sundar On 11/23/2015 8:05 PM, Hannes Wallnöfer wrote: Please review JDK-8141407: Wrong evaluation of a != a when a = NaN: http://cr.openjdk.java.net/~hannesw/8141407/ Thanks, Hannes