Re: Review request for JDK-8192970: Element getters/setters with fixed key fail to link properly

2017-12-06 Thread Jim Laskey (Oracle)
Please wait for Sundar > On Dec 6, 2017, at 3:52 PM, Attila Szegedi wrote: > > Is it okay to commit this with one +1 or should I wait for another approval? > > Thanks, > Attila. > >> On 2017. Dec 4., at 16:36, Hannes Wallnöfer >> wrote: >>

Re: Review request for JDK-8192970: Element getters/setters with fixed key fail to link properly

2017-12-06 Thread Attila Szegedi
Is it okay to commit this with one +1 or should I wait for another approval? Thanks, Attila. > On 2017. Dec 4., at 16:36, Hannes Wallnöfer > wrote: > > Took me some time to spot the difference in behaviour (adaptation of method > type in Binder)! > > +1 > >

Re: Review request for JDK-8192970: Element getters/setters with fixed key fail to link properly

2017-12-04 Thread Hannes Wallnöfer
D'oh! I blindly clicked on that links of course :) > Am 04.12.2017 um 17:05 schrieb Attila Szegedi : > > I know, it’s subtle; that’s why I decided to describe it in detail :-) > >> On 2017. Dec 4., at 16:36, Hannes Wallnöfer >> wrote: >> >>

Re: Review request for JDK-8192970: Element getters/setters with fixed key fail to link properly

2017-12-04 Thread Attila Szegedi
I know, it’s subtle; that’s why I decided to describe it in detail :-) > On 2017. Dec 4., at 16:36, Hannes Wallnöfer > wrote: > > Took me some time to spot the difference in behaviour (adaptation of method > type in Binder)! > > +1 > > Hannes > >> Am

Re: Review request for JDK-8192970: Element getters/setters with fixed key fail to link properly

2017-12-04 Thread Hannes Wallnöfer
Took me some time to spot the difference in behaviour (adaptation of method type in Binder)! +1 Hannes > Am 04.12.2017 um 13:40 schrieb Attila Szegedi : > > Please review JDK-8192970 "Element getters/setters with fixed key fail to > link properly" at

Review request for JDK-8192970: Element getters/setters with fixed key fail to link properly

2017-12-04 Thread Attila Szegedi
Please review JDK-8192970 "Element getters/setters with fixed key fail to link properly" at for Note that this is unrelated to the previous refactoring (8191878), it is present even