Re: Review request for JDK-8193296: Parser should not eagerly transform delete expressions

+1 Hannes > Am 13.12.2017 um 21:19 schrieb Attila Szegedi : > > I updated the webrev with @bug and @summary in the tests: > > > Attila. > >> On Dec 11, 2017, at 6:26 PM, Sundararajan Athijegannathan >> wrote: >> >> Hi, >> >> 1) @

Re: Review request for JDK-8193296: Parser should not eagerly transform delete expressions

Looks good. -Sundar On 14/12/17, 1:49 AM, Attila Szegedi wrote: I updated the webrev with @bug and @summary in the tests: Attila. On Dec 11, 2017, at 6:26 PM, Sundararajan Athijegannathan wrote: Hi, 1) @bug and @summary are for d

Re: Review request for JDK-8193296: Parser should not eagerly transform delete expressions

I updated the webrev with @bug and @summary in the tests: Attila. > On Dec 11, 2017, at 6:26 PM, Sundararajan Athijegannathan > wrote: > > Hi, > > 1) @bug and @summary are for documentation purpose - explain what the test is > all

Re: Review request for JDK-8193296: Parser should not eagerly transform delete expressions

Hi, 1) @bug and @summary are for documentation purpose - explain what the test is all about (without having to look at JIRA...) 2) @modules is needed only if you want to add module exports for internal packages from other modules to your test (equivalent to --add-exports in java command line

Re: Review request for JDK-8193296: Parser should not eagerly transform delete expressions

Thanks! I admittedly cribbed the various @tags from the neighboring JDK_8188098_Test class :-). I take it “@run testng …” is meaningful and understood by jtreg then, so I can leave that as it is? I tried to find other examples and stumbled upon e.g. JDK_8184723_Test which specifies “@run main/o

Re: Review request for JDK-8193296: Parser should not eagerly transform delete expressions

* Test misses copyright comment * you may want to add @bug and @summary line in jtreg comment section Other than that, +1 -Sundar On 10/12/17, 9:52 PM, Attila Szegedi wrote: Please review JDK-8193296 "Parser should not eagerly transform delete expressions" at

Review request for JDK-8193296: Parser should not eagerly transform delete expressions

Please review JDK-8193296 "Parser should not eagerly transform delete expressions" at > for