RFR(S): 8144221: fix Nashorn shebang argument handling on Mac/Linux

2015-12-14 Thread Michael Haupt
Dear all, please review this change. Bug: https://bugs.openjdk.java.net/browse/JDK-8144221 Webrev: http://cr.openjdk.java.net/~mhaupt/8144221/webrev.00 The fix for Cygwin is pending and tracked by JDK-8145305. Thanks, Michael -- Dr. Michael Haupt | Principal Member

Re: RFR(S): 8144221: fix Nashorn shebang argument handling on Mac/Linux

2015-12-14 Thread Marcus Lagergren
+1 > On 14 Dec 2015, at 11:09, Michael Haupt wrote: > > Dear all, > > please review this change. > Bug: https://bugs.openjdk.java.net/browse/JDK-8144221 > Webrev: http://cr.openjdk.java.net/~mhaupt/8144221/webrev.00 > > The fix for Cygwin is pending and tracked by JDK-8145305. > > Thanks, >

Re: Review request for JDK-8144020: Remove long as an internal numeric type

2015-12-14 Thread Marcus Lagergren
+1. This is awesome work, Hannes! /M > On 11 Dec 2015, at 16:15, Hannes Wallnoefer > wrote: > > Please review JDK-8144020: Remove long as an internal numeric type: > > http://cr.openjdk.java.net/~hannesw/8144020/webrev.01/ > > Attila already reviewed a previous version of this patch: > > ht

Re: RFR(S): 8144221: fix Nashorn shebang argument handling on Mac/Linux

2015-12-14 Thread Jim Laskey (Oracle)
+1 > On Dec 14, 2015, at 6:09 AM, Michael Haupt wrote: > > Dear all, > > please review this change. > Bug: https://bugs.openjdk.java.net/browse/JDK-8144221 > Webrev: http://cr.openjdk.java.net/~mhaupt/8144221/webrev.00 > > The fix for Cygwin is pending and tracked by JDK-8145305. > > Thanks,

Re: JFokus VM Tech Day 2016

2015-12-14 Thread Marcus Lagergren
Guys. Sadly Paul couldn’t make it, but we have replaced him with Simon Ritter, who will be wearing his new Azul hat. You are all welcome to attend! https://www.jfokus.se/jfokus/jvmtech.jsp /M /M > On 19 Nov 2015, at 17:17, Marcus Lagergren wrote: >

RFR 8145314: jjs tab-completion should support camel case completion

2015-12-14 Thread Sundararajan Athijegannathan
Please review http://cr.openjdk.java.net/~sundar/8145314/ for https://bugs.openjdk.java.net/browse/JDK-8145314 Thanks, -Sundar

Re: Review request for JDK-8144914: Eagerly lookup browser JS object class in BrowserJSObjectLinker

2015-12-14 Thread Attila Szegedi
2nd review, please? On Tue, Dec 8, 2015 at 12:58 PM, Sundararajan Athijegannathan < sundararajan.athijegannat...@oracle.com> wrote: > +1 > > -Sundar > > > On 12/8/2015 5:23 PM, Attila Szegedi wrote: > >> Please review JDK-8144914 "Eagerly lookup browser JS object class in >> BrowserJSObjectLinker

Re: RFR 8145314: jjs tab-completion should support camel case completion

2015-12-14 Thread Michael Haupt
Hi Sundar, lower-case thumbs up. Best, Michael > Am 14.12.2015 um 16:05 schrieb Sundararajan Athijegannathan > : > > Please review http://cr.openjdk.java.net/~sundar/8145314/ for > https://bugs.openjdk.java.net/browse/JDK-8145314 > > Thanks, > -Sundar -- Dr. Mic

Re: Review request for JDK-8144914: Eagerly lookup browser JS object class in BrowserJSObjectLinker

2015-12-14 Thread Hannes Wallnoefer
Sorry, I missed the intial request. +1 Hannes Am 2015-12-14 um 16:44 schrieb Attila Szegedi: 2nd review, please? On Tue, Dec 8, 2015 at 12:58 PM, Sundararajan Athijegannathan < sundararajan.athijegannat...@oracle.com> wrote: +1 -Sundar On 12/8/2015 5:23 PM, Attila Szegedi wrote: Pleas

Re: RFR 8145314: jjs tab-completion should support camel case completion

2015-12-14 Thread Hannes Wallnoefer
+1 Am 2015-12-14 um 16:05 schrieb Sundararajan Athijegannathan: Please review http://cr.openjdk.java.net/~sundar/8145314/ for https://bugs.openjdk.java.net/browse/JDK-8145314 Thanks, -Sundar

Re: Use of long in Nashorn

2015-12-14 Thread Hannes Wallnoefer
For the record, I tried the integer index optimization for array iterators, but didn't really see a difference running a microbenchmark using Array.prototype.forEach, so I left it out after all. Hannes Am 2015-12-11 um 16:30 schrieb Hannes Wallnoefer: Am 2015-12-11 um 16:21 schrieb Attila Sze

nashorn migration

2015-12-14 Thread Wyatt, Steven
Hi, You have listed "nashorn:mozilla_script.js" as the compatibility script instead of "nashorn:mozilla_compat.js" in the section "loading compatibility script so that script runs on rhino and nashorn". https://wiki.openjdk.java.net/display/Nashorn/Rhino+Migration+Guide