Review request for JDK-8147845: Varargs Array functions still leaking longs

Please review JDK-8147845: Varargs Array functions still leaking longs: webrev: http://cr.openjdk.java.net/~hannesw/8147845/webrev/ bug: https://bugs.openjdk.java.net/browse/JDK-8147845 Thanks, Hannes

Re: Review request for JDK-8147845: Varargs Array functions still leaking longs

+1 PS. Minor: toNumber overload accepting long and returning Number is bit confusing. Too many toNumber overloads and a overload returning a different type... -Sundar On 1/21/2016 3:21 PM, Hannes Wallnoefer wrote: Please review JDK-8147845: Varargs Array functions still leaking longs: webr

Re: Review request for JDK-8147845: Varargs Array functions still leaking longs

Hi Hannes, lower-case thumbs up. Best, Michael > Am 21.01.2016 um 10:51 schrieb Hannes Wallnoefer > : > > Please review JDK-8147845: Varargs Array functions still leaking longs: > > webrev: http://cr.openjdk.java.net/~hannesw/8147845/webrev/ > bug: https://bugs.openjdk.java.net/browse/JDK-81

Re: Review request for JDK-8147845: Varargs Array functions still leaking longs

Thanks for the review. I propose to rename that method to "toNarrowestNumber", which also reflects better what it does. Does that sound ok? Hannes Am 2016-01-21 um 11:12 schrieb Sundararajan Athijegannathan: +1 PS. Minor: toNumber overload accepting long and returning Number is bit confusin

Re: Review request for JDK-8147845: Varargs Array functions still leaking longs

+1 On 1/21/2016 4:29 PM, Hannes Wallnoefer wrote: Thanks for the review. I propose to rename that method to "toNarrowestNumber", which also reflects better what it does. Does that sound ok? Hannes Am 2016-01-21 um 11:12 schrieb Sundararajan Athijegannathan: +1 PS. Minor: toNumber overload

Re: Review request for JDK-8147845: Varargs Array functions still leaking longs

+1 both on current changes and on naming the method “toNarrowestNumber”. Attila. > On Jan 21, 2016, at 11:59 AM, Hannes Wallnoefer > wrote: > > Thanks for the review. I propose to rename that method to > "toNarrowestNumber", which also reflects better what it does. Does that sound > ok? > >

Re: Review request for backport of JDK-8143896: java.lang.Long is implicitly converted to double

+1 > On 20 Jan 2016, at 15:14, Hannes Wallnoefer > wrote: > > Please review backport of JDK-8143896: java.lang.Long is implicitly converted > to double: > > http://cr.openjdk.java.net/~hannesw/8143896/webrev-8u/ > > This builds on the JDK-8144020 backport which I posted earlier. Some manual

Re: Review request for backport of JDK-8143896: java.lang.Long is implicitly converted to double

+1 On 1/20/2016 7:44 PM, Hannes Wallnoefer wrote: Please review backport of JDK-8143896: java.lang.Long is implicitly converted to double: http://cr.openjdk.java.net/~hannesw/8143896/webrev-8u/ This builds on the JDK-8144020 backport which I posted earlier. Some manual merging was necessary

Re: Review request for JDK-8133299: Nashorn Java adapters should not early bind to functions

This is great! The code is so much better now. +1 /M > On 15 Jan 2016, at 16:38, Attila Szegedi wrote: > > Please review the second take on JDK-8133299 "Nashorn Java adapters should > not early bind to functions" at > for >