Re: approval request for JDK-8138906:Test test/script/trusted/JDK-8087292.js intermittently fails

2016-05-27 Thread Marcus Lagergren
+1 > On 26 May 2016, at 18:30, Srinivas Dama wrote: > > Hi, > > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8138906 > Jdk9 review thread : > http://mail.openjdk.java.net/pipermail/nashorn-dev/2016-February/005991.html > Jdk8u-webrev : http://cr.openjdk.java.net/~sdama/81

Re: RFR 8157789: Nashorn sample/test.js should not use undocumented System property

2016-05-27 Thread Marcus Lagergren
+1 > On 25 May 2016, at 06:38, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8157789/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8157789 > > -Sundar >

Re: RFR 8157680: Callback parameter of any JS builtin implementation should accept any Callable

2016-05-27 Thread Marcus Lagergren
+1 > On 24 May 2016, at 15:52, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8157680/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8157680 > > Thanks, > > -Sundar >