RFR: 8170322: Specialized functions convert booleans to numbers

Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8170322 Webrev: http://cr.openjdk.java.net/~hannesw/8170322/webrev/ This adds a new „convertsNumericArgs“ property to the SpecializedFunction annotation that defines whether it is safe to convert non-numeric arguments for this functi

Re: RFR: 8170322: Specialized functions convert booleans to numbers

+1 > On Nov 25, 2016, at 7:52 AM, Hannes Wallnöfer > wrote: > > Please review: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8170322 > Webrev: http://cr.openjdk.java.net/~hannesw/8170322/webrev/ > > This adds a new „convertsNumericArgs“ property to the SpecializedFunction > annotation t

Re: RFR: 8170322: Specialized functions convert booleans to numbers

+1. If I understand it correctly, it was only Array.concat and Array.push that needed this? That’s good, it means it wasn't a really widespread problem. Attila. > On 25 Nov 2016, at 12:52, Hannes Wallnöfer > wrote: > > Please review: > > Bug: https://bugs.openjdk.java.net/browse/JDK-817032

Re: RFR: 8170322: Specialized functions convert booleans to numbers

Thanks for the review. > Am 25.11.2016 um 14:31 schrieb Attila Szegedi : > > If I understand it correctly, it was only Array.concat and Array.push that > needed this? That’s good, it means it wasn't a really widespread problem. > Yes, those are the only number-specialized functions we have tha

RFR: 8161579: Array-like AbstractJSObject-based instance not treated as array by native array functions

Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8161579 Webrev: http://cr.openjdk.java.net/~hannesw/8161579/webrev/ Thanks, Hannes

Re: RFR: 8161579: Array-like AbstractJSObject-based instance not treated as array by native array functions

+1 > On Nov 25, 2016, at 11:19 AM, Hannes Wallnöfer > wrote: > > Please review: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8161579 > Webrev: http://cr.openjdk.java.net/~hannesw/8161579/webrev/ > > Thanks, > Hannes