+1
> On Oct 13, 2017, at 5:36 AM, Hannes Wallnöfer
> wrote:
>
> Please review:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8027302
> Webrev: http://cr.openjdk.java.net/~hannesw/8027302/webrev.01
>
> ES6 and ES5 require different handling regarding
+1
-Sundar
On 13/10/17, 7:49 PM, Hannes Wallnöfer wrote:
Am 13.10.2017 um 14:35 schrieb Sundararajan
Athijegannathan:
36 } catch (e if e instanceof SyntaxError) {
37 Assert.assertTrue(e instanceof SyntaxError);
38 }
39
In test. Do you
Am 13.10.2017 um 14:35 schrieb Sundararajan Athijegannathan
:
>
>
> 36 } catch (e if e instanceof SyntaxError) {
> 37 Assert.assertTrue(e instanceof SyntaxError);
> 38 }
> 39
>
> In test. Do you want to just catch catch(e) ?
>
Indeed. I forgot
+1
> On Oct 13, 2017, at 11:25 AM, Hannes Wallnöfer
> wrote:
>
> I uploaded a new webrev, please review:
>
> http://cr.openjdk.java.net/~hannesw/8068513/webrev.02/
>
> Changes to previous webrev:
>
> - updated to consolidated repository layout
> - fixed typos
I uploaded a new webrev, please review:
http://cr.openjdk.java.net/~hannesw/8068513/webrev.02/
Changes to previous webrev:
- updated to consolidated repository layout
- fixed typos and improved/added some comments
- improved test
Thanks,
Hannes
> Am 11.09.2017 um 16:18 schrieb Hannes
Please review:
Bug: https://bugs.openjdk.java.net/browse/JDK-8027302
Webrev: http://cr.openjdk.java.net/~hannesw/8027302/webrev.01
ES6 and ES5 require different handling regarding unencoding Unicode escapes in
keywords and identifiers. This patch makes handling more compliant and more
36 } catch (e if e instanceof SyntaxError) {
37 Assert.assertTrue(e instanceof SyntaxError);
38 }
39
In test. Do you want to just catch catch(e) ?
-Sundar
On 13/10/17, 2:06 PM, Hannes Wallnöfer wrote:
Please review:
Bug: https://bugs.openjdk.java.net/browse/JDK-8027302
Webrev: