RFR: 8193567: Conversion of comparison nodes affects local slots in optimistic continuation

2017-12-21 Thread Hannes Wallnöfer
Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8193567 Webrev: http://cr.openjdk.java.net/~hannesw/8193567/webrev.00/ I’ve tried finding a smaller fix like just tagging the child nodes of all comparisons as non-optimistic, but that didn't fix the problem as those nodes could still

Review request for JDK-8193295: Remove no longer used COMMALEFT

2017-12-21 Thread Attila Szegedi
Please review JDK-8193295 "Remove no longer used COMMALEFT" at for I love deleting code :-) COMMALEFT was an odd duck, as there’s not really anything in the ES specification that’d requir

Re: Dynalink and delete

2017-12-21 Thread Attila Szegedi
Hi Marc, So… this took about a year and a half to happen, but I’m happy to announce that there’s now a REMOVE operation in Dynalink. The latest EA of JDK10 contains it:

Re: Review request for JDK-8193295: Remove no longer used COMMALEFT

2017-12-21 Thread Hannes Wallnöfer
Interesting. I bet the answer is in the commits from before we went open source. +1 I assume this is for JDK 11? Hannes > Am 21.12.2017 um 19:20 schrieb Attila Szegedi : > > Please review JDK-8193295 "Remove no longer used COMMALEFT" at >

Re: Dynalink and delete

2017-12-21 Thread Marc Downie
Attila, Followed the reviews and commits with anticipation, pulling the changes and building this evening. Assuming it all goes well, I'll have it in front of students writing code in two weeks time. Many thanks! Marc. On Thu, Dec 21, 2017 at 2:59 PM, Attila Szegedi wrote: > Hi Marc, > > So…

Re: RFR: 8193567: Conversion of comparison nodes affects local slots in optimistic continuation

2017-12-21 Thread Jim Laskey (Oracle)
+1 > On Dec 21, 2017, at 11:36 AM, Hannes Wallnöfer > wrote: > > Please review: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8193567 > Webrev: http://cr.openjdk.java.net/~hannesw/8193567/webrev.00/ > > I’ve tried finding a smaller fix like just tagging the child nodes of all > comparis