Re: RFR 8190698: jjs tool of jdk.scripting.nashorn.shell module should not statically depend on java.desktop

+1 Hannes > Am 03.11.2017 um 10:10 schrieb Sundararajan Athijegannathan > : > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8190698 > Webrev: http://cr.openjdk.java.net/~sundar/8190698/webrev.00 > > Thanks, > -Sundar

Re: RFR:JDK-8186807:JSObject gets ScriptFunction when ScriptObjectMirror is expected

+1 Hannes > Am 03.11.2017 um 13:27 schrieb Sundararajan Athijegannathan > : > > +1 > > -Sundar > > On 03/11/17, 5:15 PM, Priya Lakshmi Muthuswamy wrote: >> Updated the webrev with modified testcase. >> >> webrev:

Re: RFR 8190698: jjs tool of jdk.scripting.nashorn.shell module should not statically depend on java.desktop

Thanks. Yes, jshell has similar dependencies for the UI part. i.e., no direct dependency on java.desktop from jdk.jshell module. -Sundar On 03/11/17, 6:27 PM, Jim Laskey (Oracle) wrote: +1 Does jshell have similar dependencies? On Nov 3, 2017, at 6:10 AM, Sundararajan

Re: RFR 8190698: jjs tool of jdk.scripting.nashorn.shell module should not statically depend on java.desktop

+1 Does jshell have similar dependencies? > On Nov 3, 2017, at 6:10 AM, Sundararajan Athijegannathan > wrote: > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8190698 > Webrev: http://cr.openjdk.java.net/~sundar/8190698/webrev.00 >

Re: RFR:JDK-8186807:JSObject gets ScriptFunction when ScriptObjectMirror is expected

+1 -Sundar On 03/11/17, 5:15 PM, Priya Lakshmi Muthuswamy wrote: Updated the webrev with modified testcase. webrev: http://cr.openjdk.java.net/~pmuthuswamy/8186807/webrev.01/ Thanks, Priya On 11/3/2017 3:11 PM, Sundararajan Athijegannathan wrote: Two suggestions: * You may want to add a

Re: RFR:JDK-8186807:JSObject gets ScriptFunction when ScriptObjectMirror is expected

Updated the webrev with modified testcase. webrev: http://cr.openjdk.java.net/~pmuthuswamy/8186807/webrev.01/ Thanks, Priya On 11/3/2017 3:11 PM, Sundararajan Athijegannathan wrote: Two suggestions: * You may want to add a check to make sure that the control reached func.call method - there

Re: RFR:JDK-8186807:JSObject gets ScriptFunction when ScriptObjectMirror is expected

Two suggestions: * You may want to add a check to make sure that the control reached func.call method - there is an assert there but the test does not assert the control reached there * class name "func" be changed to "Func" or some such (capitalization of class names) -Sundar On

RFR 8190698: jjs tool of jdk.scripting.nashorn.shell module should not statically depend on java.desktop

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8190698 Webrev: http://cr.openjdk.java.net/~sundar/8190698/webrev.00 Thanks, -Sundar

RFR:JDK-8186807:JSObject gets ScriptFunction when ScriptObjectMirror is expected

Hi, Please review JDK-8186807: JSObject gets ScriptFunction when ScriptObjectMirror is expected JBS: https://bugs.openjdk.java.net/browse/JDK-8186807 webrev: http://cr.openjdk.java.net/~pmuthuswamy/8186807/webrev.00/ Thanks, Priya