Re: RFR: 8223451: Make optimistic types disabled by default

2019-07-09 Thread Jim Laskey
+1 > On Jul 9, 2019, at 11:48 AM, Hannes Wallnöfer > wrote: > > Please review: > > JBS: https://bugs.openjdk.java.net/browse/JDK-8223451 > Webrev: http://cr.openjdk.java.net/~hannesw/8223451/webrev.00/ > > A lot of Nashorn usage we see is with command line scripts from the Node.js > and Web

Re: RFR: 8223451: Make optimistic types disabled by default

2019-07-09 Thread Sundararajan Athijegannathan
Looks good! -Sundar On 09/07/19, 8:18 PM, Hannes Wallnöfer wrote: Please review: JBS: https://bugs.openjdk.java.net/browse/JDK-8223451 Webrev: http://cr.openjdk.java.net/~hannesw/8223451/webrev.00/ A lot of Nashorn usage we see is with command line scripts from the Node.js and Web

Re: RFR: Update double-conversion to version 3.1.5

2019-07-09 Thread Attila Szegedi
+1. This is really a refreshingly small change :-) Attila. > On 2019. Jul 9., at 15:23, Hannes Wallnöfer > wrote: > > Please review the update of the Java port of the V8 double conversion library > to the most recent release. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8227391 >

RFR: Update double-conversion to version 3.1.5

2019-07-09 Thread Hannes Wallnöfer
Please review the update of the Java port of the V8 double conversion library to the most recent release. JBS: https://bugs.openjdk.java.net/browse/JDK-8227391 Webrev: http://cr.openjdk.java.net/~hannesw/8227391/webrev.00/ Although the commit log between the two releases is very long [1] (I’m