Re: Some Nashorn PRs need review love

Hi, Approved 4 out of 5. Clarification sought for 1 Thanks, -Sundar On 17/12/20 2:40 am, Attila Szegedi wrote: I have several Nashorn PRs up for review; I started working my way through the JBS bug tracker. If anyone with OpenJDK reviewer privileges feels like helping, you can contribute a

Re: Standalone Nashorn 15.0 is out!

Laskey, Iris Clark, Vladimir Kozlov, Dalibor Topić, Erik Duveblad, Sundararajan Athijegannathan, Rémi Forax, Mandy Chung, and Aleksey Shipilev for help, support, and advice along the way. Very excited to hear back from users! Attila. [0] https://search.maven.org/artifact/org.openjdk.nashorn

Re: Standalone Nashorn is coming for Java 15+

Given that we use "anonymous class" for JS "evals",  a level of indirection won't hurt here. i.e., a Eval class instance (with instance would report name like "" ) that uses "hidden class" Lookup may work. -Sundar On 19/10/20 9:41 pm, fo...@univ-mlv.fr wrote: - Mail original - De:

Re: New Nashorn Project Lead: Attila Szegedi

+100 :) Congrats Attila! -Sundar On 12/10/20 3:10 pm, Hannes Wallnoefer wrote: Excellent news, Attila! I couldn’t think of a better person for this task than you. I’m glad there is a future for Nashorn, and I hope I’ll be able to contribute something to the project somewhere down the road.

Re: Resigning as OpenJDK Nashorn Project Lead

Just a clarification. You said "the original Rhino project" - which seems to suggest that Nashorn is related to Rhino. Nashorn is not related to Rhino project at all. Nashorn is a different implementation of ES 5.1 and select few features of ES6 . -Sundar On 05/10/20 11:50 pm,

RFR 8246113: re-visit javax/script test that still requires jdk.scripting.nashorn module

Hi, Please review - removing these tests. Bug: https://bugs.openjdk.java.net/browse/JDK-8246113 Webrev: http://cr.openjdk.java.net/~sundar/8246113/webrev.00/ Thanks -Sundar

RFR jdk15 8247956: remove scripts under bin/nashorn and doc/nashorn/source

Please review Bug: https://bugs.openjdk.java.net/browse/JDK-8247956 Webrev: http://cr.openjdk.java.net/~sundar/8247956/webrev.00/ Thanks -Sundar

Re: RFR 8241749: Remove the Nashorn JavaScript Engine

Thanks Mandy. I'll add bug id next to @ignore before push. Thanks, -Sundar On 16/04/20 2:50 am, Mandy Chung wrote: This looks okay to me. Can you add the bug ID next to @ignore that will make it easier to find the JBS issue?   These test bugs are filed with P4 but I think they should be

Re: RFR 8241749: Remove the Nashorn JavaScript Engine

Thanks for spotting this Magnus! I'll fix this before push. Thanks. -Sundar On 15/04/20 10:44 pm, Magnus Ihse Bursie wrote: On 2020-04-15 17:56, sundararajan.athijegannat...@oracle.com wrote: Please review. Nashorn script engine modules (jdk.scripting.nashorn, jdk.scripting.nashorn.shell)

RFR 8241749: Remove the Nashorn JavaScript Engine

Please review. Nashorn script engine modules (jdk.scripting.nashorn, jdk.scripting.nashorn.shell) and jjs tool are removed. Bug: https://bugs.openjdk.java.net/browse/JDK-8241749 JEP: https://openjdk.java.net/jeps/372 CSR: https://bugs.openjdk.java.net/browse/JDK-8241751 Webrev:

Re: RFR: 8223451: Make optimistic types disabled by default

Looks good! -Sundar On 09/07/19, 8:18 PM, Hannes Wallnöfer wrote: Please review: JBS: https://bugs.openjdk.java.net/browse/JDK-8223451 Webrev: http://cr.openjdk.java.net/~hannesw/8223451/webrev.00/ A lot of Nashorn usage we see is with command line scripts from the Node.js and Web

Re: Nashorn on the module-path

Thanks. I'll check it out. -Sundar On 27/05/19, 3:10 PM, Christian Stein wrote: On Mon, May 27, 2019 at 11:37 AM Sundararajan Athijegannathan <mailto:sundararajan.athijegannat...@oracle.com>> wrote: How can this be reproduced at out end? I compiled a small example proj

Re: Nashorn on the module-path

How can this be reproduced at out end? Thanks -Sundar On 26/05/19, 2:47 PM, Christian Stein wrote: Have you brought this up on nashorn-dev... No, but cc-ed that list now. ...as this might require digging into the dynalink linker and how method handles are used. Do you think it's still

Re: RFR: 8222528: Fix javadoc headers in Nashorn sources

Looks good -Sundar On 16/04/19, 6:26 PM, Hannes Wallnöfer wrote: Please review: Issue: https://bugs.openjdk.java.net/browse/JDK-8222528 Webrev: http://cr.openjdk.java.net/~hannesw/8222528/webrev.00/ Javadoc now requires that headings be consistent with accessibility guidelines. Since h1 is

Re: RFR: JDK-8214491: Upgrade to JLine 3.9.0

to fix this problem here: http://cr.openjdk.java.net/~jlahoda/8214491/webrev.05/ Delta from previous patch: http://cr.openjdk.java.net/~jlahoda/8214491/webrev.delta.04.05/ What do you think? Thanks, Jan On 10.12.2018 11:14, Sundararajan Athijegannathan wrote: Hi Jan, Tests are fine. Because

Re: RFR: JDK-8214491: Upgrade to JLine 3.9.0

ed output should hopefully be OK. Updated patch: http://cr.openjdk.java.net/~jlahoda/8214491/webrev.04/index.html Delta from previous: http://cr.openjdk.java.net/~jlahoda/8214491/webrev.delta.03.04/ How does this look? Thanks! Jan On 10.12.2018 06:20, Sundararajan Athijegannathan wrote: I built j

Re: RFR: JDK-8214491: Upgrade to JLine 3.9.0

I built jdk and ran nashorn tests with this patch. Two tests fail with this patch - but those tests pass without this patch: [testng] Test test/nashorn/script/nosecurity/JDK-8055034.js failed at line 1 - [testng] expected: 'jjs> var x = Object.create(null);' [testng] found:

Re: RFR: JDK-8214491: Upgrade to JLine 3.9.0

CC'ing nashorn-dev. -Sundar On 05/12/18, 10:48 PM, Jan Lahoda wrote: Hi Robert, On 4.12.2018 23:59, Robert Field wrote: I saw no issues with JShell tool and test portions of the webrev. I did not review the nashorn changes. Thanks for looking at this! Testing it: editing multi-line

Re: RFR: 8214795: Add safety check to dynalink inner class lookup

Looks good. -Sundar On 05/12/18, 8:03 PM, Hannes Wallnöfer wrote: Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8214795 Webrev: http://cr.openjdk.java.net/~hannesw/8214795/webrev.00/ This is to make sure we use the right inner classes regardless of the order of classes

Re: RFR: 8214795: Add safety check to dynalink inner class lookup

Looks good -Sundar On 05/12/18, 8:03 PM, Hannes Wallnöfer wrote: Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8214795 Webrev: http://cr.openjdk.java.net/~hannesw/8214795/webrev.00/ This is to make sure we use the right inner classes regardless of the order of classes

Re: RFR: 8210943: Hiding of inner classes not resolved properly

That should have been "do I miss something here?" :) -Sundar On 01/12/18, 11:43 AM, Sundararajan Athijegannathan wrote: Class.getClasses() javadoc does not mention anything about order of classes returned. https://docs.oracle.com/javase/10/docs/api/java/lang/Class.html#getClasses()

Re: RFR: 8210943: Hiding of inner classes not resolved properly

Class.getClasses() javadoc does not mention anything about order of classes returned. https://docs.oracle.com/javase/10/docs/api/java/lang/Class.html#getClasses() Do we need a check using Class.getDeclaringClass() or do I something here? Thanks, -Sundar On 30/11/18, 4:44 PM, Attila Szegedi

Re: casting typed array to java byte[] is it possible?

Hi, Yes, I reproduced the issue with jdk8 (haven't tried graal.js though). Please file bug(s). -Sundar On 12/10/18, 7:29 PM, Paulo Lopes wrote: Interesting enough, with Java>=9 the length is reported correctly, so in the case of: var bb = java.nio.ByteBuffer.allocateDirect(12) var ab = new

Re: casting typed array to java byte[] is it possible?

Hi Paulo Lopes, ArrayBuffer can be created using a nio ByteBuffer. // you could create a ByteBuffer in Java & pass var bb = java.nio.ByteBuffer.allocateDirect(100) // create JS ArrayBuffer backed by Java ByteBuffer instance var ab = new ArrayBuffer(bb) var ia = new Int8Array(ab) ia[0] = 10

Re: Extending a Java class

schrieb Sundararajan Athijegannathan: In your example, it seems you're trying to add a new method to the subtype created in script. That is not supported. You can override existing methods of superclass - but not add a new method to the Java type. Bummer! resourcetrysuggester.js added new fields

Re: Extending a Java class

Java.super. For example, you can invoke Java.super(filter).fireMatchNode(). So the workaround for this case would be add utility function outside for "setEnabled". Hope this helps, -Sundar On 28/09/18, 3:19 PM, Axel Dörfler wrote: Am 28/09/2018 um 11:34 schrieb Sundararajan Athij

Re: Nashorn script security permissions not working for .js

Make sure that test.js is loaded via URLReader or load primitive. i.e., nashorn engine should load the script pointed via URL - if you pass FileReader or loaded content to engine.eval, Nashorn will treat it as sandboxed - i.e., script loaded from untrusted source. If it still does not work for

Re: RFR 8204492 Add deprecation annotation to Nashorn APIs and warning to nashorn, jjs

, then -Xlint:all,-deprecation should be enough to add. The current argument for jdk.scripting.nashorn is -Xlint:all (if I'm not mistaken). /Erik On 2018-06-27 08:59, Sundararajan Athijegannathan wrote: Hi Erik, Yes, nashorn is warning free afaik. Besides nashorn is being deprecated. No further

Re: RFR 8204492 Add deprecation annotation to Nashorn APIs and warning to nashorn, jjs

PM, Erik Joelsson wrote: Hello Sundar, Adding $(DISABLE_WARNINGS) disables a lot of warnings. Isn't jdk.scripting.nashorn pretty much warning frree now? What warnings do you really need to disable? /Erik On 2018-06-26 21:19, Sundararajan Athijegannathan wrote: Forgot to CC build-dev

Re: RFR 8204492 Add deprecation annotation to Nashorn APIs and warning to nashorn, jjs

Forgot to CC build-dev for makefile changes. -Sundar On 27/06/18, 9:46 AM, Sundararajan Athijegannathan wrote: Please review. Bug https://bugs.openjdk.java.net/browse/JDK-8204492 Webrev http://cr.openjdk.java.net/~sundar/8204492/webrev.01 Related: JEP http://openjdk.java.net/jeps/335 CSR

RFR 8204492 Add deprecation annotation to Nashorn APIs and warning to nashorn, jjs

Please review. Bug https://bugs.openjdk.java.net/browse/JDK-8204492 Webrev http://cr.openjdk.java.net/~sundar/8204492/webrev.01 Related: JEP http://openjdk.java.net/jeps/335 CSR https://bugs.openjdk.java.net/browse/JDK-8205594 Thanks, -Sundar

CSR - JDK-8205594 - Add deprecation annotation to Nashorn APIs and warning to nashorn, jjs

Please review: https://bugs.openjdk.java.net/browse/JDK-8205594 Thanks, -Sundar

Re: RFR: 8204290: Add check to limit number of capture groups

Looks good -Sundar On 05/06/18, 6:14 PM, Hannes Wallnöfer wrote: Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8204290 Webrev: http://cr.openjdk.java.net/~hannesw/8204290/webrev/ This (like the previous RFR) is another backport from jruby/joni. Thanks, Hannes

Re: RFR: 8204288: Matching the end of a string followed by an empty greedy regex and a word boundary fails

Looks good. PS. Reply to http://mail.openjdk.java.net/pipermail/nashorn-dev/2018-June/007393.html -Sundar

Re: RFR: 8200716: Object propertyIsEnumerable buggy behavior on short integer-string key

+1 -Sundar On 07/05/18, 10:10 PM, Hannes Wallnöfer wrote: Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8200716 Webrev: http://cr.openjdk.java.net/~hannesw/8200716/webrev/ Thanks, Hannes

Re: RFR: 8198816: AbstractScriptEngine.getScriptContext creation of SimpleScriptContext is inefficient

+1 -Sundar On 23/04/18, 8:34 AM, Hannes Wallnöfer wrote: Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8198816 Webrev: http://cr.openjdk.java.net/~hannesw/8198816/webrev/ Thanks, Hannes

Re: RFR: 8201466: Nashorn: defineProperty setters/getters on prototype object ignored with numeric property names

Looks good. -Sundar On 23/04/18, 6:49 AM, Hannes Wallnöfer wrote: Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8201466 Webrev: http://cr.openjdk.java.net/~hannesw/8201466/webrev/ Thanks, Hannes

Re: JSObject without Java-based conversion to JSON

Please note that a general Java object graph may involve circular references. Without modifying JSON somehow, it is not possible to handle such cases. That said, please do file a rfe with your ideas and we can discuss. -Sundar On 11/04/18, 10:18 AM, Victor Polischuk wrote: Dear all, I

Re: RFR 8200215: 17th loop of "let foo = ''"; throws ReferenceError

Am 26.03.2018 um 14:00 schrieb Sundararajan Athijegannathan<sundararajan.athijegannat...@oracle.com>: Please review http://cr.openjdk.java.net/~sundar/8200215/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8200215 Thanks, -Sundar

Re: RFR 8200215: 17th loop of "let foo = ''"; throws ReferenceError

, not on 17th :-) Attila. On 2018. Mar 26., at 14:00, Sundararajan Athijegannathan<sundararajan.athijegannat...@oracle.com> wrote: Please review http://cr.openjdk.java.net/~sundar/8200215/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8200215 Thanks, -Sundar

RFR 8200215: 17th loop of "let foo = ''"; throws ReferenceError

Please review http://cr.openjdk.java.net/~sundar/8200215/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8200215 Thanks, -Sundar

Re: RFR: 8199869: Missing copyright headers in nashorn source code

+1 -Sundar On 21/03/18, 3:11 PM, Hannes Wallnöfer wrote: Please review (trivial change, two copyright headers added): Bug: https://bugs.openjdk.java.net/browse/JDK-8199869 Webrev: http://cr.openjdk.java.net/~hannesw/8199869/webrev/ Thanks, Hannes

Re: Any way to support expando props on Java objects?

Hi, Haven't gone through the referred code. Do you want to add more properties to a Java object apart from "bean properties" inferred? If so, you can write your own dynalink linker with jdk9. See also: API doc: https://docs.oracle.com/javase/9/docs/api/jdk.dynalink-summary.html Sample:

Re: RFR: 8199443: Nashorn multithread bottleneck with "use strict"

+1 -Sundar On 15/03/18, 7:00 PM, Hannes Wallnöfer wrote: Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8199443 Webrev: http://cr.openjdk.java.net/~hannesw/8199443/webrev/ If we make sure the property maps for strict functions and arguments are set up correctly (they weren’t

Re: Is there a way to reference the engine from a linker?

Hi, Dynalink and its pluggable linkers are independent of Nashorn. If you want to access the current engine, you've to arrange to pass it. Thanks, -Sundar On 16/03/18, 12:32 AM, Paulo Lopes wrote: Hi, I'm writing a guarded linker to allow custom casting from JSObject to Vertx custom types.

Re: RFR: 8199236: Nashorn uses deprecated HTML tags in Javadoc

+1 -Sundar On 07/03/18, 10:38 PM, Hannes Wallnöfer wrote: Please review 8199236: Nashorn uses deprecated HTML tags in Javadoc: Bug: https://bugs.openjdk.java.net/browse/JDK-8199236 Webrev: http://cr.openjdk.java.net/~hannesw/8199236/webrev/ Thanks, Hannes

Re: defineClass doesn't exist on extended ClassLoader

Hi, Two things: * Nashorn allows access only to public methods and fields (of exported) classes only. * With Java.extend, Nashorn adds public overrides of all non-final protected methods of the superclass. ClassLoader.definePackage is non-final protected method. ClassLoader.defineClass is

Re: loading file twice locks the file

Will you please file a bug with test case attached? Thanks, -Sundar On 01/02/18, 6:49 PM, yikes aroni wrote: I find that, when i load a javascript file in java *twice *using this pattern ScriptObjectMirror som = scriptEngine.eval("load('c:/temp/test.js');"); it locks the JS file (prevents

Re: Da Capo: JSON "clear text" signatures

Just to be clear. so.. do you want a toString (static method?) variant in java.lang.Double class as per this specification? -Sundar On 29/01/18, 7:45 PM, Anders Rundgren wrote: On 2018-01-29 14:52, Hannes Wallnöfer wrote: Hi Anders, I think I lack the context required to understand what

Re: RFR: 8147614: add jjs test for -t option

+1 -Sundar On 23/01/18, 12:04 PM, Priya Lakshmi Muthuswamy wrote: Hi, Kindly review JDK-8147614: add jjs test for -t option JBS: https://bugs.openjdk.java.net/browse/JDK-8147614 webrev: http://cr.openjdk.java.net/~pmuthuswamy/8147614/webrev.00/ Thanks, Priya

RFR 8195829 Parsing a nameless ES6 class results in a thrown NullPointerException.

Please review. Webrev: http://cr.openjdk.java.net/~sundar/8195829/webrev.00/index.html Bug: https://bugs.openjdk.java.net/browse/JDK-8195829 Thanks, -Sundar

Re: RFR [11]: 8194985: JavaAdapterBytecodeGenerator passes invalid type descriptor to ASM

+1 -Sundar On 12/01/18, 2:56 PM, Hannes Wallnöfer wrote: Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8194985 Webrev: http://cr.openjdk.java.net/~hannesw/8194985/webrev.00/ Thanks, Hannes

Re: Loss of engine scope in a new Thread

can you use send us a simple compilable, runnable test case that can reproduce your issue? Thanks, -Sundar On 05/01/18, 12:07 PM, Koray wrote: Hello, I have a structure which creates a new thread for each client that is connected and assigns a new ScriptContext to them along with a new

Re: JavaScript/Nashorn mailing list?

Not all ES6 features are implemented - only a small subset is in jdk 9. Please report with the exact issue... -Sundar On 08/01/18, 9:45 PM, Michel Trudeau wrote: Olivier, Nashorn-dev is the best mailing list to ask questions.

Re: RFR: 8193508: Expressions in split literals must never be optimistic

+1 -Sundar On 14/12/17, 11:08 PM, Hannes Wallnöfer wrote: Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8193508 Webrev: http://cr.openjdk.java.net/~hannesw/8193508/webrev.00/ The actual fix is quite simple: stop visiting when we encounter a split object or array literal in

Re: RFR 8193779: Fix copyright header in nashorn builtin scripts

Yes, I'll. -Sundar On 19/12/17, 4:00 PM, Alan Bateman wrote: On 19/12/2017 10:38, Sundararajan Athijegannathan wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8193799 Webrev: http://cr.openjdk.java.net/~sundar/8193799/webrev.00/ Looks fine. Will you push this to jdk

RFR 8193779: Fix copyright header in nashorn builtin scripts

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8193799 Webrev: http://cr.openjdk.java.net/~sundar/8193799/webrev.00/ Thanks, -Sundar

Re: Review request for JDK-8193371: Use Dynalink REMOVE operation in Nashorn

+1 Nice work! -Sundar On 14/12/17, 5:12 PM, Attila Szegedi wrote: Please review JDK-8193371 "Use Dynalink REMOVE operation in Nashorn" at for It looks bigger than it is. let me quickly

Re: Review request for JDK-8193296: Parser should not eagerly transform delete expressions

Looks good. -Sundar On 14/12/17, 1:49 AM, Attila Szegedi wrote: I updated the webrev with @bug and @summary in the tests:<http://cr.openjdk.java.net/~attila/8193296/webrev.02.jdk> Attila. On Dec 11, 2017, at 6:26 PM, Sundararajan Athijegannathan<sundararajan.athijegannat...@o

Re: RFR: 8069338: Implement sharedScopeCall for optimistic types

“ and „nashorn.shared.scope.get.threshold“ system properties, respectively. http://cr.openjdk.java.net/~hannesw/8069338/webrev.02/ Hannes Am 12.12.2017 um 14:00 schrieb Sundararajan Athijegannathan<sundararajan.athijegannat...@oracle.com>: +1 PS. Not sure if it is worth making SHARED_GET_THR

Re: RFR: 8069338: Implement sharedScopeCall for optimistic types

+1 PS. Not sure if it is worth making SHARED_GET_THRESHOLD configurable via System property? -Sundar On 12/12/17, 5:51 PM, Hannes Wallnöfer wrote: Thanks for the review, Attila. I’ve uploaded a new webrev with your suggested changes (including making ScriptObject.getProto(int) accept 0

Re: Review request for JDK-8193296: Parser should not eagerly transform delete expressions

? Attila. On Dec 11, 2017, at 8:18 AM, Sundararajan Athijegannathan<sundararajan.athijegannat...@oracle.com> wrote: * Test misses copyright comment * you may want to add @bug and @summary line in jtreg comment section Other than that, +1 -Sundar On 10/12/17, 9:52 PM, Attila Szegedi

Re: RFR:JDK-8193137:Nashorn crashes when given an empty script file

+1 -Sundar On 08/12/17, 2:56 PM, Priya Lakshmi Muthuswamy wrote: Thanks Sundar. I have modified the test. updated webrev : http://cr.openjdk.java.net/~pmuthuswamy/8193137/webrev.01/ Thanks, Priya On 12/8/2017 2:40 PM, Sundararajan Athijegannathan wrote: Looks good. The test uses $EXEC(&qu

Re: RFR:JDK-8193137:Nashorn crashes when given an empty script file

Looks good. The test uses $EXEC("rm..."). Better to avoid that [what about Windows?] - use Java API to delete file instead./ / -Sundar On 08/12/17, 2:09 PM, Priya Lakshmi Muthuswamy wrote: Hi, Please review JDK-8193137 : Nashorn crashes when given an empty script file JBS :

Re: RFR: 8191891: Update minumum Ant version in Nashorn build.xml

+1 PS. Is there a doc where we documented this? -Sundar On 28/11/17, 7:56 PM, Hannes Wallnöfer wrote: Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8191891 Webrev: http://cr.openjdk.java.net/~hannesw/8191891/webrev.00/ Thanks, Hannes

Re: Review request for JDK-8191878: Reduce code duplication in BeanLinker

Looks good -Sundar On 27/11/17, 12:21 AM, Attila Szegedi wrote: Hey folks, I’m able to spend some free time again on OpenJDK development, and one thing I have on my plate is adding a REMOVE operation to Dynalink. This CR however, is not yet it: that will require a CCC sponsorship etc. as

RFR 8135178: importPackage not working even with load "Mozilla compatibility script"

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8135178 Webrev: http://cr.openjdk.java.net/~sundar/8135178/webrev.00/ Thanks, -Sundar

Re: RFR: 8191819: String.prototype.match should follow ES6 specification

+1 -Sundar On 23/11/17, 8:12 PM, Hannes Wallnöfer wrote: Sorry, the test in the first webrev uses replace() instead of match(), which already works as expected. New webrev with correct test is here: http://cr.openjdk.java.net/~hannesw/8191819/webrev.01/ Hannes Am 23.11.2017 um 14:18

RFR 8191810: jjs should avoid hard coded javadoc base url for shift-tab documentation feature

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8191810 Webrev: http://cr.openjdk.java.net/~sundar/8191810/webrev.00/ Thanks, -Sundar

RFR 8191771: nashorn ant makefile uses javadoc -link which may fail

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8191771 Webrev: http://cr.openjdk.java.net/~sundar/8191771/webrev.00/ Thanks, -Sundar

RFR 8068741: javax.script.ScriptEngineFactory.getMethodCallSyntax() spec allows null passed as an object

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8068741 Webrev: http://cr.openjdk.java.net/~sundar/8068741/webrev.00/index.html Thanks, -Sundar

RFR 8191306: Math.abs corner case with optimistic typing

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8191306 Webrev: http://cr.openjdk.java.net/~sundar/8191306/webrev.00/index.html Thanks -Sundar

Re: RFR: 8191133: Ant task to fetch underscore.js requires gzip decoding option

+1 -Sundar On 14/11/17, 2:58 PM, Hannes Wallnöfer wrote: Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8191133 Webrev: http://cr.openjdk.java.net/~hannesw/8191133/webrev/ Thanks, Hannes

Re: RFR: 8185119: Uninitialized const when using multiple threads

+1 -Sundar On 13/11/17, 10:55 PM, Hannes Wallnöfer wrote: Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8185119 Webrev: http://cr.openjdk.java.net/~hannesw/8185119/webrev/ Thanks, Hannes

Re: RFR: 8191131: Nashorn test comparator breaks comparator contract

+1 PS. Wonder why this was not caught earlier... -Sundar On 13/11/17, 10:19 PM, Hannes Wallnöfer wrote: Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8191131 Webrev: http://cr.openjdk.java.net/~hannesw/8191131/webrev/ Thanks, Hannes

Re: RFR:JDK-8190391:nashorn: "!!" of nonzero even integer var becomes false when returned

+1 Yep. 0 and 1 are only allowed. -Sundar On 13/11/17, 1:27 PM, Attila Szegedi wrote: +1. Nice catch. Feels like an implementation detail, but the JVM specification is indeed unclear on the behavior in case there's a bytecode method doing this: public static func(I)Z 0 iload 0

Re: RFR: 8190427 : Test for JDK-8165198 fails intermittently because of GC

+1 -Sundar On 07/11/17, 6:15 PM, Hannes Wallnöfer wrote: Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8190427 Webrev: http://cr.openjdk.java.net/~hannesw/8190427/webrev.02/ This started as simple bug fix but turned into a full refactoring of the code that manages property

RFR 8190795: jjs should show javadoc for java methods on shift-tab

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8190795 Webrev: http://cr.openjdk.java.net/~sundar/8190795/webrev.00/ Piggybacking refactoring of other functions implemented in script (browse, load etc.) so that we can avoid multi-line hard coded string in java sources. -Sundar

Re: RFR 8190698: jjs tool of jdk.scripting.nashorn.shell module should not statically depend on java.desktop

Thanks. Yes, jshell has similar dependencies for the UI part. i.e., no direct dependency on java.desktop from jdk.jshell module. -Sundar On 03/11/17, 6:27 PM, Jim Laskey (Oracle) wrote: +1 Does jshell have similar dependencies? On Nov 3, 2017, at 6:10 AM, Sundararajan Athijegannathan

Re: RFR:JDK-8186807:JSObject gets ScriptFunction when ScriptObjectMirror is expected

+1 -Sundar On 03/11/17, 5:15 PM, Priya Lakshmi Muthuswamy wrote: Updated the webrev with modified testcase. webrev: http://cr.openjdk.java.net/~pmuthuswamy/8186807/webrev.01/ Thanks, Priya On 11/3/2017 3:11 PM, Sundararajan Athijegannathan wrote: Two suggestions: * You may want to add

Re: RFR:JDK-8186807:JSObject gets ScriptFunction when ScriptObjectMirror is expected

Two suggestions: * You may want to add a check to make sure that the control reached func.call method - there is an assert there but the test does not assert the control reached there * class name "func" be changed to "Func" or some such (capitalization of class names) -Sundar On

RFR 8190698: jjs tool of jdk.scripting.nashorn.shell module should not statically depend on java.desktop

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8190698 Webrev: http://cr.openjdk.java.net/~sundar/8190698/webrev.00 Thanks, -Sundar

RFR 8190217: Add a JS "static checker" sample for nashorn parser API

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8190217 Webrev: http://cr.openjdk.java.net/~sundar/8190217/webrev.00/ Thanks -Sundar

Re: RFR:8165198:Inconsistent values with JavaImporter after accessing undefined variable

+1 On 23/10/17, 1:02 PM, Hannes Wallnöfer wrote: +1 Hannes Am 23.10.2017 um 06:16 schrieb Priya Lakshmi Muthuswamy: Hi, Please review JDK-8165198: Inconsistent values with JavaImporter after accessing undefined variable JBS:

Re: RFR: 8189617: Remove undocumented --print-mem-usage option

+1 -Sundar On 19/10/17, 5:26 PM, Jim Laskey (Oracle) wrote: +1 On Oct 19, 2017, at 7:32 AM, Hannes Wallnöfer wrote: Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8189617 Webrev: http://cr.openjdk.java.net/~hannesw/8189617/webrev.00/ Thanks,

Re: RFR: 8068513: Adding elements to a javascript 'object' (a map) is slow

property called „nashorn.propmap.queue.threshold“. It’s otherwise unchanged. http://cr.openjdk.java.net/~hannesw/8068513/webrev.03/ Hannes Am 16.10.2017 um 07:43 schrieb Sundararajan Athijegannathan<sundararajan.athijegannat...@oracle.com>: Is it worthwhile adding configura

Re: RFR: 8068513: Adding elements to a javascript 'object' (a map) is slow

Is it worthwhile adding configurability for QUEUE_THREASHOLD? Not a per context property/option - but even a simple nashorn.* system property perhaps? +1 other than that -Sundar On 13/10/17, 7:55 PM, Hannes Wallnöfer wrote: I uploaded a new webrev, please review:

Re: RFR: 8027302: Identifiers containing unicode escapes are not recognized as reserved words

+1 -Sundar On 13/10/17, 7:49 PM, Hannes Wallnöfer wrote: Am 13.10.2017 um 14:35 schrieb Sundararajan Athijegannathan<sundararajan.athijegannat...@oracle.com>: 36 } catch (e if e instanceof SyntaxError) { 37 Assert.assertTrue(e instanceof SyntaxError); 38 } 39 In test.

Re: RFR: 8027302: Identifiers containing unicode escapes are not recognized as reserved words

36 } catch (e if e instanceof SyntaxError) { 37 Assert.assertTrue(e instanceof SyntaxError); 38 } 39 In test. Do you want to just catch catch(e) ? -Sundar On 13/10/17, 2:06 PM, Hannes Wallnöfer wrote: Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8027302 Webrev:

RFR 8180274: Fix links in nashorn documentation

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8180274 Webrev: http://cr.openjdk.java.net/~sundar/8180274/webrev.00/ Thanks, -Sundar

RFR 8188082: autoimports.js sample is broken

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8188082 Webrev: http://cr.openjdk.java.net/~sundar/8188082/webrev.00/ PS. Piggybacking to push another sample to demonstrate the use of es6 tagged template literal to create a java object Thanks, -Sundar

Re: RFR: 8186815: Java.from has a bug, when element is ScriptObject

+1 -Sundar On 27/09/17, 8:14 PM, Hannes Wallnöfer wrote: Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8186815 Webrev: http://cr.openjdk.java.net/~hannesw/8186815/webrev/ Thanks, Hannes

RFR 8188023: Avoid -source and -target javac options in nashorn ant compilation

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8188023 Webrev: http://cr.openjdk.java.net/~sundar/8188023/webrev.00/index.html Piggybacking to take care of few javac warnings as well. Thanks, -Sundar

Re: RFR:8133623:JDK-8055034.js and JDK-8130127.js fail in nashorn nightly

+1 On 27/09/17, 2:34 PM, Hannes Wallnöfer wrote: +1 Hannes Am 27.09.2017 um 08:17 schrieb Priya Lakshmi Muthuswamy: Hi, --patch-module actually works and added it to back to the testcase. webrev :

Re: RFR: 8187962: Optimistic types ignore JavaAdapter return types

+1 -Sundar On 26/09/17, 10:35 PM, Hannes Wallnöfer wrote: Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8187962 Webrev: http://cr.openjdk.java.net/~hannesw/8187962/webrev/ Thanks, Hannes

Re: RFR: 8185257(Nashorn AST is missing nodes when a for-loop contains a VariableDeclarationList)

To: Srinivas Dama Cc: Nashorn-dev Subject: Re: RFR: 8185257(Nashorn AST is missing nodes when a for-loop contains a VariableDeclarationList) +1 Hannes Am 12.09.2017 um 19:38 schrieb Sundararajan Athijegannathan<sundararajan.athijegannat...@oracle.com>: +1 -Sundar On 12/09/17, 11

RFR 8187934: dropping a shebang script in src/sample/nashorn directory results in test failure

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8187934 Webrev: http://cr.openjdk.java.net/~sundar/8187934/webrev.00/ PS. Piggybacking a sample script (psgrep.js) Thanks, -Sundar

Re: RFR:8187362:Nashorn unsigned right shift operator unexpectedly returns floating-point

+1 -Sundar On 22/09/17, 11:59 AM, Priya Lakshmi Muthuswamy wrote: Moved the changes to jdk10/master repo. webrev: http://cr.openjdk.java.net/~pmuthuswamy/8187362/webrev.02/ Thanks, Priya On 9/13/2017 2:48 PM, Hannes Wallnöfer wrote: +1 Hannes Am 13.09.2017 um 07:21 schrieb Sundararajan

Re: RFR:8181792:nashorn samples/exec.js has some incorrect examples

+1 -Sundar On 22/09/17, 11:59 AM, Priya Lakshmi Muthuswamy wrote: Moved the changes to jdk10/master repo: webrev: http://cr.openjdk.java.net/~pmuthuswamy/8181792/webrev.02/ Thanks, Priya On 9/8/2017 5:06 PM, Jim Laskey (Oracle) wrote: +1 On Sep 8, 2017, at 6:42 AM, Priya Lakshmi

Re: RFR:8186180:Symbol.__proto__ results in error with format string placeholder

+1 -Sundar On 22/09/17, 11:58 AM, Priya Lakshmi Muthuswamy wrote: Moved the changes to jdk10/master repo. webrev : http://cr.openjdk.java.net/~pmuthuswamy/8186180/webrev.02/ Thanks, Priya On 9/7/2017 2:07 PM, Sundararajan Athijegannathan wrote: +1 On 07/09/17, 2:02 PM, Priya Lakshmi

  1   2   3   4   5   6   7   >