Re: RFR 8166296:add documentation for Date,RegExp,Error,JSON objects

2016-09-20 Thread Sundararajan Athijegannathan 
+1

-Sundar


On 9/19/2016 11:13 PM, Srinivas Dama wrote:
> Hello,
>
> Please review http://cr.openjdk.java.net/~sdama/8166296/webrev.00/  for 
> https://bugs.openjdk.java.net/browse/JDK-8166296 
>
> Regards,
> Srinivas

Re: RFR 8166296:add documentation for Date,RegExp,Error,JSON objects

2016-09-20 Thread Michael Haupt 
Hi Srini,

> Am 19.09.2016 um 19:43 schrieb Srinivas Dama :
> Please review http://cr.openjdk.java.net/~sdama/8166296/webrev.00/  for 
> https://bugs.openjdk.java.net/browse/JDK-8166296 

thumbs up, provided these changes are applied:

+Date.parse=returns a number, the UTC time value corresponding to the date and 
time interpreted from given string argument, returns NAN if the argument is 
unrecognisable string

... from the given string argument, returns NaN if the argument is not 
recognized

+Date.UTC=returns number of milliseconds in the given date object since january 
1,1970,00:00:00 universal time

returns the number ... since January 1, 1970, 00:00:00 universal time

(returns *the* number / string value / year ... - please apply in all other 
places)
(month names are written in upper case, please apply in all other places)
(spaces after commas, please apply in all other places)

+Date.prototype.toString=returns string value representing given date object

... representing the given date object

+Date.prototype.toDateString=returns string value representing date portion of 
the given date object

... representing the date portion ...

(also ... representing *the* time portion ... etc., please apply accordingly 
elsewhere)

+Date.prototype.valueOf=returns number of milliseconds between 1 january 1970 
00:00:00 UTC and the given date

Please use a consistent date formatting. "1. January 1970" or "January 1, 1970" 
in all places.

+Date.prototype.getDay=returns the day of the week for the given date according 
to local time, 0 represents sunday

Sunday (day names begin with upper case - please apply in all places)

+Date.prototype.getSeconds=returns the seconds in the given date, according to 
locale time

Is it "local time" or "locale time"? (I think "local" is right.) Please be 
consistent in all places.

+Date.prototype.toUTCString=converts given date to a string using UTC time zone

converts the given date ...


Best,

Michael


-- 

 
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
  Oracle is committed to developing 
practices and products that help protect the environment

RFR 8166296:add documentation for Date,RegExp,Error,JSON objects

2016-09-19 Thread Srinivas Dama 
Hello,

Please review http://cr.openjdk.java.net/~sdama/8166296/webrev.00/  for 
https://bugs.openjdk.java.net/browse/JDK-8166296 

Regards,
Srinivas