Re: [naviserver-devel] Large file upload dilemma

2007-10-24 Thread Vasiljevic Zoran
On 24.10.2007, at 00:34, Vlad Seryakov wrote: > Yes, i already tested it and just commited, please review if anybody > have time. I am sure it does not break anything and if maxupload > parameters is not set will never be activated but it is pretty useful. > Now it is possible to upload/download

Re: [naviserver-devel] nsconfigrw

2007-10-24 Thread Vasiljevic Zoran
On 23.10.2007, at 23:52, Vasiljevic Zoran wrote: > Now that we "solved" that one So, it is done. I will shortly check-in the changes. But before I do, a question: how "seriously" should I take those tests: test cfg-4.3 {type check: bool != int} -body { ns_getconfig -bool section cfg-4.

Re: [naviserver-devel] nsconfigrw

2007-10-24 Thread Stephen Deasey
On 10/24/07, Vasiljevic Zoran <[EMAIL PROTECTED]> wrote: > > On 23.10.2007, at 23:52, Vasiljevic Zoran wrote: > > > Now that we "solved" that one > > So, it is done. I will shortly check-in the changes. > But before I do, a question: how "seriously" should > I take those tests: > > test cfg-4.3

Re: [naviserver-devel] Large file upload dilemma

2007-10-24 Thread Vlad Seryakov
ns_conn contentfile will be non empty only in such situation, in normal cases it is always empty Vasiljevic Zoran wrote: > On 24.10.2007, at 00:34, Vlad Seryakov wrote: > >> Yes, i already tested it and just commited, please review if anybody >> have time. I am sure it does not break anything an

Re: [naviserver-devel] Large file upload dilemma

2007-10-24 Thread Vasiljevic Zoran
On 24.10.2007, at 18:13, Vlad Seryakov wrote: > ns_conn contentfile will be non empty only in such situation, in > normal > cases it is always empty > So the non-empty [ns_conn contentfile] means we need to parse. Otherwise server parses. Allright. I will take the freedom to make the changes

Re: [naviserver-devel] nsconfigrw

2007-10-24 Thread Vasiljevic Zoran
On 24.10.2007, at 18:36, Stephen Deasey wrote: > A buffer size of 'no' doesn't make any > sense. But ns_getconfig section buffer no (module A) ns_getconfig section buffer 1000 (module B) is the application problem, not ours. This is simply clash of config params. I do not think we nee

Re: [naviserver-devel] nsconfigrw

2007-10-24 Thread Vasiljevic Zoran
On 24.10.2007, at 18:36, Stephen Deasey wrote: > ns_getconfig both uses and declares. It declares so that an admin can > set the correct value. Some code may only need to check whether a > buffer size is greater than zero (is it true?), but that doesn't make > it a boolean config option. A buffer

Re: [naviserver-devel] nsconfigrw

2007-10-24 Thread Vasiljevic Zoran
On 24.10.2007, at 19:09, Vasiljevic Zoran wrote: > So > >ns_getconfig -bool section param 1 >ns_getconfig -int section param >configuration parameter is not an integer > > would make you happy? > Lets stop and think about consequences of this... Underneath, some integer will be used

Re: [naviserver-devel] Large file upload dilemma

2007-10-24 Thread Vlad Seryakov
Actually i put this for windows as well, only mmap now does not compile for window, but i never tested, does not have windows Vasiljevic Zoran wrote: > On 24.10.2007, at 18:13, Vlad Seryakov wrote: > >> ns_conn contentfile will be non empty only in such situation, in >> normal >> cases it is a

Re: [naviserver-devel] Large file upload dilemma

2007-10-24 Thread Vasiljevic Zoran
On 24.10.2007, at 19:58, Vlad Seryakov wrote: > Actually i put this for windows as well, only mmap now does not > compile > for window, but i never tested, does not have windows I have written NsMemMap and NsMemUmap (nsd/nswin.c). This should work. --

Re: [naviserver-devel] nsconfigrw

2007-10-24 Thread Stephen Deasey
On 10/24/07, Vasiljevic Zoran <[EMAIL PROTECTED]> wrote: > > On 24.10.2007, at 19:09, Vasiljevic Zoran wrote: > > > So > > > >ns_getconfig -bool section param 1 > >ns_getconfig -int section param > >configuration parameter is not an integer > > > > would make you happy? > > > > Lets sto

Re: [naviserver-devel] nsconfigrw

2007-10-24 Thread Vasiljevic Zoran
On 24.10.2007, at 20:35, Stephen Deasey wrote: > On 10/24/07, Vasiljevic Zoran <[EMAIL PROTECTED]> wrote: >> >> On 24.10.2007, at 19:09, Vasiljevic Zoran wrote: >> >>> So >>> >>>ns_getconfig -bool section param 1 >>>ns_getconfig -int section param >>>configuration parameter is not an

Re: [naviserver-devel] nsconfigrw

2007-10-24 Thread Stephen Deasey
On 10/24/07, Vasiljevic Zoran <[EMAIL PROTECTED]> wrote: > > OK. I buy everything. > > So, supported conversion rules: > > Unknown -> any > Int -> Unknown > Bool-> Unknown Unknown -> Int || Bool Valid for the value stored in the config itself. On the way out: Int || Bool ->

Re: [naviserver-devel] nsconfigrw

2007-10-24 Thread Vasiljevic Zoran
On 24.10.2007, at 21:31, Stephen Deasey wrote: > Yes. It is (now in CVS). We now only have knownBugs left, but we will never bee case-insensitive I guess. Now: where you want to go today? Couple of issues still left: persistence wideint type parameter introspection (you name it) Chee

[naviserver-devel] nsconfigrw: persistence

2007-10-24 Thread Stephen Deasey
On 10/23/07, Vasiljevic Zoran <[EMAIL PROTECTED]> wrote: > > What we haven't figured out is: how the changed > params are saved (made persistent) when a change > occurs? This is by no means trivial to do. > Perhaps the easiest would be to have some kind of > dbm-like storage (qdbm is nice and LGPL)

Re: [naviserver-devel] nsconfigrw

2007-10-24 Thread Stephen Deasey
On 10/24/07, Vasiljevic Zoran <[EMAIL PROTECTED]> wrote: > > On 24.10.2007, at 21:31, Stephen Deasey wrote: > > > Yes. > > It is (now in CVS). Does the same apply to min and max? It seems like it logically should. - This SF