[Nbd] Happy Ugadi 2016 from Sobha Dream Acres

-- Find and fix application performance issues faster with Applications Manager

[Nbd] BOOK Your DREAM Villa For just 7 LAKHS Pay REST on POSSESSION*.

-- Find and fix application performance issues faster with Applications Manager

[Nbd] [RFC PATCH] doc: Add new NBD_FLAG_BLOCK_SIZE extension

Existing NBD servers often have limitations, such as requiring actions to be aligned to block sizes or limiting maximum transactions to avoid denial of service attacks; for example, qemu's NBD server refuses any transaction larger than 32M. But to date, clients have to learn these limitations via

Re: [Nbd] [PATCHv8] Improve documentation for TLS

On 04/11/2016 01:27 AM, Alex Bligh wrote: >>> +There is no requirement for the client or server to complete a negotiation >>> +if it does not wish to do so. If the client does not find an export it >>> +is looking for (for instance) it may simply close the TCP connection. >>> +Under certain

Re: [Nbd] [PATCH v6 0/2] SHOULD / MUST / MAY

Eric, Wouter, Arrgh. I just did a v6 myself based on top of the TLS patch. Now we have a v6 that goes on top of the TLS patch or a v6 that goes underneath it. Take your pick. Alex On 11 Apr 2016, at 20:25, Eric Blake wrote: > ping > > On 04/07/2016 03:29 PM, Eric Blake

Re: [Nbd] [PATCHv5] docs/proto.md: Clarify SHOULD / MUST / MAY etc

Wouter, On 11 Apr 2016, at 20:17, Wouter Verhelst wrote: > Can you rebase? Done. Rebased on top of the TLS patch so we don't get another issue. -- Alex Bligh -- Find and fix application performance

Re: [Nbd] [PATCH v6 0/2] SHOULD / MUST / MAY

ping On 04/07/2016 03:29 PM, Eric Blake wrote: > v6: add another wording fixup, then rebase to master > > Since the two patches conflict, and since Alex' patch is a > conflict magnet for later patches, I'm hoping we can get > both of these in sooner rather than later. > > Alex Bligh (1): >

Re: [Nbd] [PATCHv2 0/6] Introduce TLS on nbdserver

On Mon, Apr 11, 2016 at 06:15:33PM +0100, Alex Bligh wrote: > This is an RFC patch to introduce TLS support on nbdserver. > > This is *NOT* production ready by any means, and is submitted for comment. > > I have added crypto-gnutls.[ch] from: > github.com/abligh/tlsproxy > which is my attempt

Re: [Nbd] [PATCH/RFC 0/3] Introduce TLS on nbdserver

Wouter, On 11 Apr 2016, at 12:42, Wouter Verhelst wrote: > On Mon, Apr 11, 2016 at 07:53:16AM +0100, Alex Bligh wrote: >> Wouter, >> >> On 11 Apr 2016, at 07:07, Wouter Verhelst wrote: >>> I'm going to reply to this series in more detail later (have to go to >>>

Re: [Nbd] [PATCHv5] docs/proto.md: Clarify SHOULD / MUST / MAY etc

On Mon, Apr 11, 2016 at 01:37:27PM +0100, Alex Bligh wrote: > Wouter, > > Looks like Eric and I are both OK with this one (though Eric wants > a follow-up patch which I think he has done elsewhere). > > Is this OK by you? Yeah, but it doesn't apply anymore (some churn since this patch was

Re: [Nbd] [PATCH] Make include of "config.h" not use system include path

Well, gcc doesn't really care about the difference much anymore (-I works for "" as wel as <>), but meh, you're probably right. On Sun, Apr 10, 2016 at 02:23:22PM +0100, Alex Bligh wrote: > The inclusion of config.h is, I believe, not meant to search > the system include path. This (nbd-debug.h)

Re: [Nbd] [PATCH/RFC 0/3] Introduce TLS on nbdserver

On Mon, Apr 11, 2016 at 07:53:16AM +0100, Alex Bligh wrote: > Wouter, > > On 11 Apr 2016, at 07:07, Wouter Verhelst wrote: > > I'm going to reply to this series in more detail later (have to go to > > work soon), but some quick notes for now: > > > > - I'm not sure I like the idea

[Nbd] [PATCHv2 3/6] Add GnuTLS infrastructure

Add configure.ac section to detect GnuTLS Add buffer.[ch] and crypto-gnutls.[ch] from https://github.com/abligh/tlsproxy Add Makefile.am changes to link these new files in Signed-off-by: Alex Bligh --- Makefile.am | 13 +- buffer.c | 225

[Nbd] [PATCHv2 4/6] Add options for TLS support for server

Signed-off-by: Alex Bligh --- man/nbd-server.5.in.sgml | 65 nbd-server.c | 8 ++ nbdsrv.h | 1 + 3 files changed, 74 insertions(+) diff --git a/man/nbd-server.5.in.sgml

[Nbd] [PATCHv2 6/6] Add TLS testing to nbd-tester-client.c

This commit adds TLS testing to nbd-tester-client and 'make check'. If TLS is not compiled in, then the test is skipped. Signed-off-by: Alex Bligh --- nbd.h | 2 + tests/run/Makefile.am | 13 +++- tests/run/certs/ca-cert.pem | 20

[Nbd] [PATCHv2 5/6] Add TLS support to server

Known problems / potential issues: * It now passes a pointer to genconf around so handle_starttls can get at the certificates. This is a pity. * It forks() the TLS proxy child using spawn_child. If we use fork() we get complaints about unknown children on SIGCHILD. If we use this method,

[Nbd] [PATCHv2 2/6] Fix whitespacing and indentation in nbd-tester-client.c

I realise whitespace changes are generally frowned on, but nbd-tester-client.c is almost impossible to edit in (e.g.) emacs even in 'linux' mode, because its whitespacing is inconsistent and does not follow the style of the rest of the package. This is a whitespace ONLY change and is the

Re: [Nbd] [PATCH] Make include of "config.h" not use system include path

On 04/10/2016 07:23 AM, Alex Bligh wrote: > The inclusion of config.h is, I believe, not meant to search > the system include path. This (nbd-debug.h) is how config.h > gets included into nbd-server.c. > > Signed-off-by: Alex Bligh > --- > nbd-debug.h | 2 +- > 1 file changed,

[Nbd] [PATCH] Fix whitespacing and indentation in nbd-tester-client.c

I realise whitespace changes are generally frowned on, but nbd-tester-client.c is almost impossible to edit in (e.g.) emacs even in 'linux' mode, because its whitespacing is inconsistent and does not follow the style of the rest of the package. This is a whitespace ONLY change and is the

[Nbd] [PATCH] Make nbd-tester-client use FIXED_NEWSTYLE negotiation

Signed-off-by: Alex Bligh --- tests/run/nbd-tester-client.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/tests/run/nbd-tester-client.c b/tests/run/nbd-tester-client.c index 06396a7..1b99fa8 100644 --- a/tests/run/nbd-tester-client.c +++

Re: [Nbd] [PATCHv5] docs/proto.md: Clarify SHOULD / MUST / MAY etc

Wouter, Looks like Eric and I are both OK with this one (though Eric wants a follow-up patch which I think he has done elsewhere). Is this OK by you? Alex On 7 Apr 2016, at 08:35, Alex Bligh wrote: > Eric, > >>> -The server MUST NOT fail an NDB_OPT_GO sent with the

[Nbd] Deals of the Day | Toolkit @Rs 129, 7W LED Bulb (Pack of 5) @Re 299, Wrench Set @Rs 249, Masks (Pack of 100) @Rs 225, Air Blower @Rs 493 and more.

Re: [Nbd] [PATCHv8] Improve documentation for TLS

Wouter, On 11 Apr 2016, at 07:10, Wouter Verhelst wrote: > Mostly there. Final note: > > On Sun, Apr 10, 2016 at 01:47:32PM +0100, Alex Bligh wrote: >> diff --git a/doc/proto.md b/doc/proto.md >> index f117394..5005552 100644 >> --- a/doc/proto.md >> +++ b/doc/proto.md >> @@

Re: [Nbd] [PATCHv8] Improve documentation for TLS

Mostly there. Final note: On Sun, Apr 10, 2016 at 01:47:32PM +0100, Alex Bligh wrote: > diff --git a/doc/proto.md b/doc/proto.md > index f117394..5005552 100644 > --- a/doc/proto.md > +++ b/doc/proto.md > @@ -195,6 +195,13 @@ request before sending the next one of the same type. > The server MAY

Re: [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On Tuesday 05 April 2016 22:50:51 Wouter Verhelst wrote: > On Tue, Apr 05, 2016 at 08:14:01AM -0600, Eric Blake wrote: > > On 04/05/2016 03:24 AM, Markus Pargmann wrote: > > > > >> +requested. > > >> + > > >> +The client SHOULD NOT read from an area that has both > > >> +

Re: [Nbd] [PATCH/RFC 0/3] Introduce TLS on nbdserver

Hi Alex, I'm going to reply to this series in more detail later (have to go to work soon), but some quick notes for now: - I'm not sure I like the idea of having a proxy to do TLS *at the server side*, although I do agree that there's an upside of "more shared code with client". To be