Re: [Nbd] [PATCH 2/5] nbd: Remove signal usage

2016-01-03 Thread Christoph Hellwig
Hi Markus, this looks great! Reviewed-by: Christoph Hellwig One thing I noticed, which might be a good cleanup in the future: > - spin_lock_irqsave(>tasks_lock, flags); > nbd->task_recv = current; > - spin_unlock_irqrestore(>tasks_lock, flags); It seems like

[Nbd] [PATCH 2/5] nbd: Remove signal usage

2016-01-02 Thread Markus Pargmann
As discussed on the mailing list, the usage of signals for timeout handling has a lot of potential issues. The nbd driver used for some time signals for timeouts. These signals where able to get the threads out of the blocking socket operations. This patch removes all signal usage and uses a