Re: [Nbd] [PATCH] nbd: use loff_t for blocksize and nbd_set_size args

2016-12-02 Thread Jens Axboe
On 12/02/2016 02:19 PM, Josef Bacik wrote: > If we have large devices (say like the 40t drive I was trying to test with) we > will end up overflowing the int arguments to nbd_set_size and not get the > right > size for our device. Fix this by using loff_t everywhere so I don't have to > think

[Nbd] [PATCH] nbd: use loff_t for blocksize and nbd_set_size args

2016-12-02 Thread Josef Bacik
If we have large devices (say like the 40t drive I was trying to test with) we will end up overflowing the int arguments to nbd_set_size and not get the right size for our device. Fix this by using loff_t everywhere so I don't have to think about this again. Thanks, Signed-off-by: Josef Bacik

Re: [Nbd] [Qemu-devel] [PATCH v3] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-12-02 Thread John Snow
On 12/02/2016 01:45 PM, Alex Bligh wrote: > John, > >>> +Some storage formats and operations over such formats express a >>> +concept of data dirtiness. Whether the operation is block device >>> +mirroring, incremental block device backup or any other operation with >>> +a concept of data

Re: [Nbd] [Qemu-devel] [PATCH v3] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-12-02 Thread Alex Bligh
John, >> +Some storage formats and operations over such formats express a >> +concept of data dirtiness. Whether the operation is block device >> +mirroring, incremental block device backup or any other operation with >> +a concept of data dirtiness, they all share a need to provide a list >> +of