Re: [Nbd] NBD_OPT_GO

2016-04-05 Thread Wouter Verhelst
On Tue, Apr 05, 2016 at 11:56:40AM -0600, Eric Blake wrote: > On 04/05/2016 11:10 AM, Wouter Verhelst wrote: > > On Tue, Apr 05, 2016 at 01:37:26PM +0100, Alex Bligh wrote: > >> proto.md is unclear on what export is selected when you use NBD_OPT_GO. I > >> take it > >> that the selected export is

Re: [Nbd] NBD_OPT_GO

2016-04-05 Thread Eric Blake
On 04/05/2016 11:10 AM, Wouter Verhelst wrote: > On Tue, Apr 05, 2016 at 01:37:26PM +0100, Alex Bligh wrote: >> proto.md is unclear on what export is selected when you use NBD_OPT_GO. I >> take it >> that the selected export is the one previously selected using NBD_OPT_SELECT. >> If that's the cas

Re: [Nbd] NBD_OPT_GO

2016-04-05 Thread Alex Bligh
On 5 Apr 2016, at 18:17, Wouter Verhelst wrote: > On Tue, Apr 05, 2016 at 04:56:28PM +0100, Alex Bligh wrote: >> What I presumed was the reason was that the client could try >> selecting disk 'foo' prior to the TLS, but a man-in-the-middle >> could (whilst cleverly hijacking the TCP session) cha

Re: [Nbd] NBD_OPT_GO

2016-04-05 Thread Alex Bligh
On 5 Apr 2016, at 18:10, Wouter Verhelst wrote: > > Mm. We could also drop NBD_OPT_SELECT completely. > > The reason I added SELECT/GO was because EXPORT_NAME has no way for the > server to report error (other than to close the connection). The spec > for GO explicitly states that the server mu

Re: [Nbd] NBD_OPT_GO

2016-04-05 Thread Wouter Verhelst
On Tue, Apr 05, 2016 at 04:56:28PM +0100, Alex Bligh wrote: > What I presumed was the reason was that the client could try > selecting disk 'foo' prior to the TLS, but a man-in-the-middle > could (whilst cleverly hijacking the TCP session) change this > to a select of disk 'bar' (which might be his

Re: [Nbd] NBD_OPT_GO

2016-04-05 Thread Wouter Verhelst
On Tue, Apr 05, 2016 at 01:37:26PM +0100, Alex Bligh wrote: > proto.md is unclear on what export is selected when you use NBD_OPT_GO. I > take it > that the selected export is the one previously selected using NBD_OPT_SELECT. > If that's the case, it should say that, and it should also say that >

Re: [Nbd] NBD_OPT_GO

2016-04-05 Thread Alex Bligh
On 5 Apr 2016, at 16:47, Eric Blake wrote: > Plausible security reason, as follows: > > Before TLS, the server can be queried about any export name, and MUST > return success for names that it is willing to export unencrypted, and > error with TLS_REQD on any export that it is unwilling to expo

Re: [Nbd] NBD_OPT_GO

2016-04-05 Thread Eric Blake
On 04/05/2016 09:24 AM, Alex Bligh wrote: > Eric, > > (apologies for using the wrong email address for me, which may mean my text > didn't > get to the list - correct one inserted) The list (should) accept posts from non-subscriber addresses (at any rate, I had several posts show up before I sub

Re: [Nbd] NBD_OPT_GO

2016-04-05 Thread Alex Bligh
Eric, (apologies for using the wrong email address for me, which may mean my text didn't get to the list - correct one inserted) >> NBD_OPT_EXPORT_NAME with name="" selects default export >> >> NBD_OPT_SELECT with name="" selects default export and returns >> the name of the default export >>

Re: [Nbd] NBD_OPT_GO

2016-04-05 Thread Eric Blake
On 04/05/2016 09:00 AM, Alex Bligh wrote: > > On 5 Apr 2016, at 14:49, Eric Blake wrote: > >> Or are you proposing that you could use either NBD_OPT_SELECT followed >> by NBD_OPT_GO (no name), OR use NBD_OPT_GO+name (no NBD_OPT_SELECT), >> both as new ways to exit the handshake phase while still

Re: [Nbd] NBD_OPT_GO

2016-04-05 Thread Alex Bligh
On 5 Apr 2016, at 14:49, Eric Blake wrote: > Or are you proposing that you could use either NBD_OPT_SELECT followed > by NBD_OPT_GO (no name), OR use NBD_OPT_GO+name (no NBD_OPT_SELECT), > both as new ways to exit the handshake phase while still keeping the > door open for error reporting? Okay

Re: [Nbd] NBD_OPT_GO

2016-04-05 Thread Eric Blake
On 04/05/2016 06:37 AM, Alex Bligh wrote: > proto.md is unclear on what export is selected when you use NBD_OPT_GO. I > take it > that the selected export is the one previously selected using NBD_OPT_SELECT. Correct. It also says that using NBD_OPT_STARTTLS (whether successful or failed) or anot

[Nbd] NBD_OPT_GO

2016-04-05 Thread Alex Bligh
proto.md is unclear on what export is selected when you use NBD_OPT_GO. I take it that the selected export is the one previously selected using NBD_OPT_SELECT. If that's the case, it should say that, and it should also say that NBD_OPT_GO MUST NOT be used until NBD_OPT_SELECT has been used. But t