Re: [nebula-dev] New Nebula Opal widgets require too recent a version of org.eclipse.swt

2018-04-15 Thread Laurent Caron
Hi

I've just fixed bug 531021[1]  and 533505 [2]. The first bug fixed some
graphical problems on the RoundedToolbar widget, and add a "radio button"
behaviour without drawing the radio circle.
The second bug allows to use former Opal widgets on older platform.

Wim, you talked about the possibility of creating a minor version 2.0.1.
What do you think about performing this release soon ?

Laurent

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=531021
[2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=533505

2018-04-11 22:27 GMT+02:00 Laurent Caron :

> Hi matthew,
>
> Thank you very much for your kind message, and you're totally right: Opal
> can run on older version of SWT, and the version has been set up to be
> close to the Oxygen Platform.
>
> Please fill a bug report, we'll fix this problem shortly !
>
> Kind regards
>
> Laurent
>
>
> 2018-04-11 17:57 GMT+02:00 matthew.web...@diamond.ac.uk <
> matthew.web...@diamond.ac.uk>:
>
>> >> Your analysis is correct. Please file a bug (a patch would be welcome
>> too ;)
>>
>> I should be able to get to that next week (unless someone else jumps in
>> first!).
>>
>>
>>
>> >> We might want to create version 2.0.1 before 2.1.0 in October.
>>
>> That’s a great idea.
>>
>>
>>
>> Thanks
>>
>> Matthew
>>
>>
>>
>>
>>
>> --
>>
>> This e-mail and any attachments may contain confidential, copyright and
>> or privileged material, and are for the use of the intended addressee only.
>> If you are not the intended addressee or an authorised recipient of the
>> addressee please notify us of receipt by returning the e-mail and do not
>> use, copy, retain, distribute or disclose the information in or attached to
>> the e-mail.
>> Any opinions expressed within this e-mail are those of the individual and
>> not necessarily of Diamond Light Source Ltd.
>> Diamond Light Source Ltd. cannot guarantee that this e-mail or any
>> attachments are free from viruses and we cannot accept liability for any
>> damage which you may sustain as a result of software viruses which may be
>> transmitted in or with the message.
>> Diamond Light Source Limited (company no. 4375679). Registered in England
>> and Wales with its registered office at Diamond House, Harwell Science and
>> Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom
>>
>>
>> ___
>> nebula-dev mailing list
>> nebula-dev@eclipse.org
>> To change your delivery options, retrieve your password, or unsubscribe
>> from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/nebula-dev
>>
>
>
___
nebula-dev mailing list
nebula-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from 
this list, visit
https://dev.eclipse.org/mailman/listinfo/nebula-dev

Re: [nebula-dev] New Nebula Opal widgets require too recent a version of org.eclipse.swt

2018-04-11 Thread Wim Jongman
Hi Matthew,

Your analysis is correct. Please file a bug (a patch would be welcome too ;)

We might want to create version 2.0.1 before 2.1.0 in October.

Cheers,

Wim

From: nebula-dev-boun...@eclipse.org [mailto:nebula-dev-boun...@eclipse.org] On 
Behalf Of matthew.web...@diamond.ac.uk
Sent: Wednesday, 11 April 2018 11:45
To: 'Nebula Dev'
Subject: [nebula-dev] New Nebula Opal widgets require too recent a version of 
org.eclipse.swt

It's great that the Opal widgets are now available as part of Eclipse Nebula, 
as of the Nebula 2.0.0 release, but we've hit a snag when trying to move to 
them.

Previously, we used the Opal widgets from https://github.com/lcaron/opal. The 
last release, 1.0.9, had a dependency on org.eclipse.swt with a minimum version 
of 3.7.2.
However, the Opal widgets from Nebula, specifically 
org.eclipse.nebula.widgets.opal.commons, depends on org.eclipse.swt with a 
minimum version of 3.106.0.

We are (still) using a target platform based on Eclipse Mars, which uses 
org.eclipse.swt version 3.104.2.v20160212-1350.
That means we can't switch to the Nebula-packaged version of the widgets.

It looks like SWT 3.106 came with Eclipse Oxygen, so anyone with an older 
target platform can't use Nebula Opal.
I notice that the other (non-Opal) Nebula widgets that depend on SWT don't 
specify any particular version, so they can be used with any target platform.

Do the Opal widgets actually require SWT 3.106+?
My guess (which could be wrong) is that when they were moved to Nebula, that 
was done using an Eclipse Oxygen IDE, and someone that got inserted as the 
minimum version required, but it's not actually needed.

Is it possible to reduce or remove the minimum SWT version that the Opal 
widgets require?
Should I open a ticket?

Thanks
Matthew

PS This is not intended as any criticism of the excellent work that Laurent has 
done. We like and use the Opal widgets.







--

This e-mail and any attachments may contain confidential, copyright and or 
privileged material, and are for the use of the intended addressee only. If you 
are not the intended addressee or an authorised recipient of the addressee 
please notify us of receipt by returning the e-mail and do not use, copy, 
retain, distribute or disclose the information in or attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual and not 
necessarily of Diamond Light Source Ltd.
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments 
are free from viruses and we cannot accept liability for any damage which you 
may sustain as a result of software viruses which may be transmitted in or with 
the message.
Diamond Light Source Limited (company no. 4375679). Registered in England and 
Wales with its registered office at Diamond House, Harwell Science and 
Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom

___
nebula-dev mailing list
nebula-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from 
this list, visit
https://dev.eclipse.org/mailman/listinfo/nebula-dev