Re: Code Review 6947917: Error in basic authentication when user name and password are long

On May 7, 2010, at 12:21 AM, Chris Hegarty wrote: > Michael, > > A minor change to the encoder used for Basic Authentication. > > Webrev: > http://cr.openjdk.java.net/~chegar/6947917/webrev.00/webrev/ Looks fine. > > > We should increase the number of bytes per line for the encoder used fo

Code Review 6947917: Error in basic authentication when user name and password are long

Michael, A minor change to the encoder used for Basic Authentication. Webrev: http://cr.openjdk.java.net/~chegar/6947917/webrev.00/webrev/ The Basic Authentication implementation, sun.net.www.protocol.http.BasicAuthentication, uses a sun.misc.BASE64Encoder to encode the Authentication heade

hg: jdk7/tl/jdk: 6946825: com.sun.net.httpserver.HttpServer; Memory Leak on Non HTTP conform open socket

Changeset: 0bda20126372 Author:chegar Date: 2010-05-06 17:17 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0bda20126372 6946825: com.sun.net.httpserver.HttpServer; Memory Leak on Non HTTP conform open socket Reviewed-by: michaelm ! src/share/classes/sun/net/httpserver/Serv

Re: Code Review Request 6946825: com.sun.net.httpserver.HttpServer; Memory Leak on Non HTTP conform open socket

Looks fine. - Michael. Chris Hegarty wrote: Hi Michael, The Server implementation keeps a list of HttpConnection instances (which hold SelektionKeyImpl instances) per connection. After accepting a new connection a HttpConnection is created and added to the list. It is never removed if the r