Re: Code Review Request: 7152856: TEST_BUG: sun/net/www/protocol/jar/B4957695.java failing on Windows

2012-04-16 Thread Kurchi Hazra
Hi, Thanks for the reviews. Here is an updated webrev: http://cr.openjdk.java.net/~khazra/7152856/webrev.01 Thanks, Kurchi On 4/15/2012 12:35 AM, Chris Hegarty wrote: On 14/04/12 16:53, Alan Bateman wrote: On 13/04/2012 17:59, Kurchi Hazra wrote: Hi, This test was failing on Windows si

hg: jdk8/tl/jdk: 7143744: (se) Stabilize KQueue SelectorProvider and make default on MacOSX

2012-04-16 Thread alan . bateman
Changeset: c0f34986d1c5 Author:alanb Date: 2012-04-16 20:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c0f34986d1c5 7143744: (se) Stabilize KQueue SelectorProvider and make default on MacOSX Reviewed-by: michaelm, chegar ! src/macosx/classes/sun/nio/ch/DefaultSelectorPro

Re: DatagramChannel

2012-04-16 Thread Alan Bateman
On 16/04/2012 14:49, Salter, Thomas A wrote: [I'm not sure if I should post this to net-dev, nio-dev or something else, so I posted to both.] I have a trivial DatagramChannel program that fails on Windows if run with Java.net.preferIPv6Addresses=true. The exception and code are included be

Re: DatagramChannel

2012-04-16 Thread Alan Bateman
On 16/04/2012 14:49, Salter, Thomas A wrote: : I also wonder why it's even an option to specify an explicit address family. According to the Java Docs this is the only place in the entire JDK that doesn't just infer the family from an address. There's no other references to ProtocolFamily

DatagramChannel

2012-04-16 Thread Salter, Thomas A
[I'm not sure if I should post this to net-dev, nio-dev or something else, so I posted to both.] I have a trivial DatagramChannel program that fails on Windows if run with Java.net.preferIPv6Addresses=true. The exception and code are included below. The problem is that when the bind parameter

Re: Code Review Request: 7015981: java.net.HttpCookie.domainMatches returns false if domain doesn't start with a dot

2012-04-16 Thread Chris Hegarty
Dmeetry, Since this is non-normative text, and already in jdk6, I think we can safely remove it. For the record, I really hate these examples here. Sometime in the future we should try cleaning up this spec, or make it very clear what they are referring to. Thanks, -Chris. On 16/04/2012

Code Review Request: 7015981: java.net.HttpCookie.domainMatches returns false if domain doesn't start with a dot

2012-04-16 Thread Dmeetry Degrave
Hi, I'm looking for a review for a doc fix, which was reviewed and fixed in jdk6. It's a straight forward port, the method's doc contains an ambiguous example and fix removes it. The whole issue is well described in cr, cr: http://bugs.sun.com/view_bug.do?bug_id=7015981 fix: http://cr.ope